Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Followers view modal. #212

Closed
wants to merge 2 commits into from

Conversation

codetheorem
Copy link
Member

@codetheorem codetheorem commented Mar 31, 2022

Signed-off-by: Hrishikesh Agarwal [email protected]

Issue Number

fixes #213

Describe the changes you've made

I have updated the modal that shows followers. Previously even after voting the user was not showing up in the modal. I have made a state which updates with the response of the API. I have also updated the Graphql query to show the username and profile picture of the user.

Describe if there is any unusual behavior (Any Warning) of your code(Write NA if there isn't)

NA

Additional context (OPTIONAL)

Refactored Code using useReducer hook.

Test plan (OPTIONAL)

  1. Login into the user-story.
  2. Check the followers of the story
  3. Vote up a story and see your name added.

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • The title of my pull request is a short description of the requested changes.

Signed-off-by: Hrishikesh Agarwal <[email protected]>
Signed-off-by: Hrishikesh Agarwal <[email protected]>
@cyntss
Copy link
Member

cyntss commented Jul 26, 2022

Closing this PR as it has been fixed already. Thanks

@cyntss cyntss closed this Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User not visible in list even after voting up or voting down
2 participants