Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing key prop and improper spacing in Voter's list #209

Open
prajwalkulkarni opened this issue Mar 30, 2022 · 0 comments · May be fixed by #210
Open

Missing key prop and improper spacing in Voter's list #209

prajwalkulkarni opened this issue Mar 30, 2022 · 0 comments · May be fixed by #210

Comments

@prajwalkulkarni
Copy link

Describe the bug

The voter's list is mapped without a key to each of the mapped children (individual voter item), causing the error Each child in a list should have a unique "key" prop.. Additionally, there's also improper spacing in the voter list item, there's an extra margin on the left, and the padding between the avatar and the username is large. This doesn't look very good to the eyes.

To Reproduce

Steps to reproduce the behavior:

  1. Click on the vote count of any story.
  2. Open the console from dev tools to see the 'key' prop missing warning.
  3. You can also notice the improper spacing in the modal, especially on the left side of the avatar.
  4. The same behavior is seen on the Storylist page and Story page timeline.

Expected behavior

A key prop should be present on every mapped item. Also, margin and padding should be correctly set to avoid improper spacing.

Logs

If applicable, add logs to help explain your problem (e.g. the error message and/or exception traceback).

key

Environment (please complete the following information):

  • OS: Windows 11
  • Browser: Chrome

Additional context

Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant