Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile inputs accepting empty values #203

Open
prajwalkulkarni opened this issue Mar 29, 2022 · 1 comment · May be fixed by #204
Open

Profile inputs accepting empty values #203

prajwalkulkarni opened this issue Mar 29, 2022 · 1 comment · May be fixed by #204

Comments

@prajwalkulkarni
Copy link

Describe the bug

On the profile page, we can add/update our bio and social handles. When we are adding or updating the values, the existing code is accepting empty values too, and no validation check is made before submitting an empty value. This is also leading to an unnecessary network call, which is an expensive task.

To Reproduce

Steps to reproduce the behavior:

  1. Login to user-story
  2. Navigate to your profile(Route: '/myProfile')
  3. Click on the pencil icon for any input field (E.g: LinkedIn username, Twitter handle, etc).
  4. This opens up a text field and a save icon beside it.
  5. Keep the input field empty(clear if any prior input was fed).
  6. Click on the save icon, we can notice that there's no validation check made on empty strings.

Expected behavior

A clear and concise description of what you expected to happen.
Ideally, the users should not be allowed to submit an empty string. If the user wants to remove any of the links or values of their profiles, a separate remove function could be added, but accepting an empty string is not a good idea.

Logs

If applicable, add logs to help explain your problem (e.g. the error message and/or exception traceback).

Environment (please complete the following information):

  • OS: Windows 11
  • Browser: Chrome

Additional context

Add any other context about the problem here.

@prajwalkulkarni
Copy link
Author

@cyntss @mharshita @SundeepChand, I'd like to work on this and get it fixed.

@prajwalkulkarni prajwalkulkarni linked a pull request Mar 29, 2022 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant