Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Signup & Signin page issue #184

Open
StarTrooper08 opened this issue Mar 21, 2022 · 7 comments · May be fixed by #206
Open

[Bug] Signup & Signin page issue #184

StarTrooper08 opened this issue Mar 21, 2022 · 7 comments · May be fixed by #206

Comments

@StarTrooper08
Copy link
Contributor

Describe the bug

A clear and concise description of what the bug is.

[Accessibility]
When we open the sign-in or sign-up page on mobile the EOS Icon on both pages looks too small.
Solution :
Icon Size can be increased a little bit.

1. Icon Issue(Header)

eosuserstory1

Steps to reproduce the behavior:

  1. Open EOS User Story webpage on mobile.
  2. Click on the sign-in button.

Expected Behavior:

A clear and concise description of what you expected to happen.
You will notice the EOS icon in the header looks too small and the language changing option dropdown is quite bigger.
The header EOS icon size should be increased.

2. Footer Overlapping

eosdesign2

Problem: The footer overlaps on the text present on sign up form
(The logic behind the footer is to hide the text, cause both the text on the sign-up form and footer talks about cookies and privacy policy)

Steps To Reproduce the Behavior:

  1. Open EOS User Story webpage on mobile.
  2. Click on the sign-in button.

Expected Behavior:

The footer should either completely overlap on the sign-up text or should be aligned properly so that it won't overlap.

Logs

If applicable, add logs to help explain your problem (e.g. the error message and/or exception traceback).

Environment (please complete the following information):

Browser: Chrome

  • OS:
  • Browser:

Additional context

Add any other context about the problem here.

@dikshashukla455
Copy link
Contributor

Screenshot (985)

I have made the changes according to your requirements. You can see the above image where I increase the size of the "user story" logo and the footers are not overlapping. If you approve it then I will make a pull request for it.

@StarTrooper08
Copy link
Contributor Author

Actually the size and overlapping changes according to different screen sizes which I m currently trying to solve.

Try for galaxy s9+ and pixel 5 device overlapping will happen and even the header alignment will break a little.

@dikshashukla455
Copy link
Contributor

In inspect, I didn't find the Samsung galaxy s9+ but I tried the Samsung galaxy s8+ which shows the same above image that I have sent. In Galaxy fold, Header will give an overlapping problem. So, what I will do - I will decrease the size of the logo and the button for below 300px devices. So, they can overlap with each other. If it is ok for you?

@dikshashukla455
Copy link
Contributor

*can't

@dikshashukla455
Copy link
Contributor

dikshashukla455 commented Mar 24, 2022

ezgif com-gif-maker (6)

Plz see the above video, I also made a pull request kindly review it. Thank you

@StarTrooper08
Copy link
Contributor Author

nice work 👍 .
UI looks good to me

@dikshashukla455
Copy link
Contributor

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants