Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Black or flake8 to make formatting much more consistent. #7

Open
Abhirup-99 opened this issue Mar 18, 2021 · 6 comments · May be fixed by #8
Open

Add Black or flake8 to make formatting much more consistent. #7

Abhirup-99 opened this issue Mar 18, 2021 · 6 comments · May be fixed by #8

Comments

@Abhirup-99
Copy link
Member

No description provided.

@D4N
Copy link
Contributor

D4N commented Mar 18, 2021

Feel free to submit a config & CI job for black.

@Abhirup-99
Copy link
Member Author

what python version should I add?

@Abhirup-99 Abhirup-99 changed the title Add Black and flake8 to make formatting much more consistent. Add Black or flake8 to make formatting much more consistent. Mar 18, 2021
@Abhirup-99
Copy link
Member Author

I skipped black, as it was colliding with flake8. We need to go with either one of them. I am in favor of using flake8, as it gives more flexibility and follows all the PEP proposals, which isn't the case with Black. Let me know what you think?

@D4N
Copy link
Contributor

D4N commented Mar 18, 2021 via email

@D4N
Copy link
Contributor

D4N commented Mar 18, 2021 via email

@Abhirup-99
Copy link
Member Author

Should I replace flake8 with black then?

@Abhirup-99 Abhirup-99 linked a pull request Mar 18, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: Add black. Abhirup-99/eos-icons-vscode
2 participants
@D4N @Abhirup-99