Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Improvements #1

Open
Yiozolm opened this issue Mar 27, 2025 · 0 comments
Open

Some Improvements #1

Yiozolm opened this issue Mar 27, 2025 · 0 comments

Comments

@Yiozolm
Copy link

Yiozolm commented Mar 27, 2025

Highly appreciate your contribution. Grazie
Here are some bugs and suggestions, I hope this helps.

  1. in models.__init__.py file, line 20 should be writen as from .stf_stanh import SymmetricalTransFormerStanH.
  2. in demo.py file, line 116, the input should be x not x_padded. leading to tensor shape error
  3. still in demo.py file, I strongly recommend that you add the function to save images. Maybe after 106. The argument save_path is a littile bit confusing
  4. The format of all codes could be clearer. I think you can delete some of the commented code.

Best wish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant