Apply suggestions from code review

Co-authored-by: Bob Dröge <[email protected]>

Author: casparvl

eessi_bot_event_handler.py

@@ -418,15 +418,15 @@ def handle_pull_request_opened_event(self, event_info, pr, req_chatlevel=ChatLev
         comment = f"Instance `{app_name}` is configured to build on:"
         for node in node_map:
             comment += f"\n- Node type `{node}`:"
-            current_partition = node_map[node]
-            if "os" in current_partition:
-                comment += f"\n  - OS: `{current_partition['os']}`"
-            if "cpu_subdir" in current_partition:
-                comment += f"\n  - CPU architecture: `{current_partition['cpu_subdir']}`"
-            if "repo_targets" in current_partition:
-                comment += f"\n  - Repositories: `{current_partition['repo_targets']}`"
-            if "accel" in current_partition:
-                comment += f"\n  - Accelerators: `{current_partition['accel']}`"
+            current_node_type = node_map[node]
+            if "os" in current_node_type:
+                comment += f"\n  - OS: `{current_node_type['os']}`"
+            if "cpu_subdir" in current_node_type:
+                comment += f"\n  - CPU architecture: `{current_node_type['cpu_subdir']}`"
+            if "repo_targets" in current_node_type:
+                comment += f"\n  - Repositories: `{current_node_type['repo_targets']}`"
+            if "accel" in current_node_type:
+                comment += f"\n  - Accelerators: `{current_node_type['accel']}`"
             comment += "\n"
 
         self.log(f"PR opened: comment '{comment}'")

tests/test_tools_filter.py

@@ -246,7 +246,7 @@ def test_matching_context(complex_filter):
     assert expected == actual
 
 
-def test_non_match_archictecture_context(complex_filter):
+def test_non_match_architecture_context(complex_filter):
     context = {"architecture": "x86_64/amd/zen4", "repository": "EESSI", "instance": "mybot", "job": 1234}
     expected = False
     actual = complex_filter.check_filters(context)

tools/commands.py

@@ -115,7 +115,7 @@ def __init__(self, cmd_str):
 
             # If no 'on:' is found in the argument list, everything that follows the 'for:' argument
             # (until the next space) is considered the argument list for the action filters
-            # Essentially, this represents a native build, i.e. the hardware we build on should be the
+            # Essentially, this represents a native build, i.e. the hardware we build for should be the
             # hardware we build on
             if not on_found:
                 for arg in cmd_as_list[1:]: