Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parameter inference #682

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

forsyth2
Copy link
Collaborator

Summary

Objectives:

  • Refactor parameter inference code to be more easily understood.
  • Document parameter inference.

Issue resolution:

Select one: This pull request is...

  • a bug fix: increment the patch version
  • a small improvement: increment the minor version
  • a new feature: increment the minor version
  • an incompatible (non-backwards compatible) API change: increment the major version

Big Change

  • To merge, I will use "Create a merge commit". That is, this change is large enough to require multiple units of work (i.e., it should be multiple commits).

1. Does this do what we want it to do?

Required:

  • Product Management: I have confirmed with the stakeholders that the objectives above are correct and complete.
  • Testing: I have added or modified at least one "min-case" configuration file to test this change. Every objective above is represented in at least one cfg.
  • Testing: I have considered likely and/or severe edge cases and have included them in testing.

If applicable:

  • Testing: this pull request introduces an important feature or bug fix that we must test often. I have updated the weekly-test configuration files, not just a "min-case" one.
  • Testing: this pull request adds at least one new possible parameter to the cfg. I have tested using this parameter with and without any other parameter that may interact with it.

2. Are the implementation details accurate & efficient?

Required:

  • Logic: I have visually inspected the entire pull request myself.
  • Logic: I have left GitHub comments highlighting important pieces of code logic. I have had these code blocks reviewed by at least one other team member.

If applicable:

  • Dependencies: This pull request introduces a new dependency. I have discussed this requirement with at least one other team member. The dependency is noted in zppy/conda, not just an import statement.

3. Is this well documented?

Required:

  • Documentation: by looking at the docs, a new user could easily understand the functionality introduced by this pull request.

4. Is this code clean?

Required:

  • Readability: The code is as simple as possible and well-commented, such that a new team member could understand what's happening.
  • Pre-commit checks: All the pre-commits checks have passed.

If applicable:

  • Software architecture: I have discussed relevant trade-offs in design decisions with at least one other team member. It is unlikely that this pull request will increase tech debt.

@forsyth2 forsyth2 added Documentation Files in `docs` modified Testing Files in `tests` modified semver: small improvement Small improvement (will increment patch version) labels Feb 11, 2025
@forsyth2 forsyth2 changed the title Issue 680 parameter docs Improve parameter inference Feb 11, 2025
Copy link
Collaborator Author

@forsyth2 forsyth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chengzhuzhang Let me know if https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.forsyth2/issue-680/parameters.html helps explain the parameter inference process a little more.

Note to self, to put docs up online:

cd docs
make html
mv _build/html /lcrc/group/e3sm/public_html/diagnostic_output/ac.forsyth2/issue-680

Comment on lines +70 to +74
TODO: Insert main table from Confluence

These parameters are required for all model-vs-model runs: ``diff_title``, ``ref_name``, ``short_ref_name``.

TODO: Insert model-vs-model table from Confluence
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://acme-climate.atlassian.net/wiki/spaces/IPD/pages/4984209586/zppy+parameters+for+e3sm_diags

It's really difficult to create tables in rst, so for a big table, Confluence seemed like the better fit. For actually including it in the docs, I suppose we could add in screenshots?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Files in `docs` modified semver: small improvement Small improvement (will increment patch version) Testing Files in `tests` modified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc]: Explain parameter inference
1 participant