Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logic for HOMME_QUAD_PREC variable not quite right #7085

Open
ndkeen opened this issue Mar 5, 2025 · 0 comments · May be fixed by #7086
Open

Logic for HOMME_QUAD_PREC variable not quite right #7085

ndkeen opened this issue Mar 5, 2025 · 0 comments · May be fixed by #7086
Labels
HOMME nvidia compiler nvidia compiler (formerly PGI)

Comments

@ndkeen
Copy link
Contributor

ndkeen commented Mar 5, 2025

Was having trouble building eamxx with nvidia compiler. #7002
As it's not clear if it supports quad precision, tried to turn it off with something like:
set(HOMME_QUAD_PREC FALSE CACHE BOOL "")
however, it was still trying to build with longdouble_kind = 16

In components/homme/src/share/kinds.F90

#ifdef HOMME_QUAD_PREC
  longdouble_kind    = 16
#else
  longdouble_kind    = 8
#endif

should probably be:

#if HOMME_QUAD_PREC
  longdouble_kind    = 16
#else
  longdouble_kind    = 8
#endif

ndk/homme/fix-HOMME_QUAD_PREC-logic
@ndkeen ndkeen added HOMME nvidia compiler nvidia compiler (formerly PGI) labels Mar 5, 2025
@ndkeen ndkeen linked a pull request Mar 5, 2025 that will close this issue
Open
bartgol added a commit that referenced this issue Mar 5, 2025
@bartgol
Merge branch 'ndk/homme/fix-HOMME_QUAD_PREC-logic' into next (PR #7086)
55383ea 
Correct macro logic for the HOMME_QUAD_PREC variable such that we can build with this off.
Currently, it's always on.

Fixes #7085

[bfb]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
HOMME nvidia compiler nvidia compiler (formerly PGI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct HOMME_QUAD_PREC logic E3SM-Project/E3SM
1 participant
@ndkeen