Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EAMxx: Incorrect Time Step Values in Sub-Stepped Processes Using timestamp().get_num_steps() #7074

Open
singhbalwinder opened this issue Mar 3, 2025 · 1 comment
Assignees
Labels
bug EAMxx PRs focused on capabilities for EAMxx

Comments

@singhbalwinder
Copy link
Contributor

I’m attempting to print the model time step in the run_impl method of an atmosphere process using auto ts = timestamp().get_num_steps();. This approach works correctly when I use it in a process that isn’t sub-stepped, such as rrtmgp, where I get the expected time step value. However, when I use the same method in processes that are sub-stepped (e.g., P3 or SHOC), the returned time step values are incorrect—they differ from the time step values logged in the atm.log.* file.

@singhbalwinder singhbalwinder added bug EAMxx PRs focused on capabilities for EAMxx labels Mar 3, 2025
@bartgol
Copy link
Contributor

bartgol commented Mar 3, 2025

Note to self. two issues to fix related to the timestamp handling in atm proc:

  • store two timestamps in the atm proc class: the start-of-step stamp and the end-of-stamp one.
  • update the start/end-of-step stamps inside the subcycling loop, right before/after calling run_impl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug EAMxx PRs focused on capabilities for EAMxx
Projects
None yet
Development

No branches or pull requests

2 participants