Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EAMxx: replace instances of vertical contraction with field utility #7058

Open
mahf708 opened this issue Feb 25, 2025 · 3 comments
Open

EAMxx: replace instances of vertical contraction with field utility #7058

mahf708 opened this issue Feb 25, 2025 · 3 comments
Assignees
Labels
code cleanup code usability EAMxx PRs focused on capabilities for EAMxx

Comments

@mahf708
Copy link
Contributor

mahf708 commented Feb 25, 2025

Goal is to replace all instances of vertical contraction1 (e.g., liqwaterpath, AODvis in diagnostics) with the vert_contraction<T>(reduced, original, weight) field utility. Before replacement, address issue with packs.

Footnotes

  1. broadly defined, vertical contraction is any reduction across the vertical dimension (LEV/ILEV), e.g., a quantity summed/averaged over its vertical dimension.

@mahf708 mahf708 added code cleanup code usability EAMxx PRs focused on capabilities for EAMxx labels Feb 25, 2025
@bartgol
Copy link
Contributor

bartgol commented Feb 25, 2025

For clarity: diagnostics do not have to use packs. ISince their input fields are already allocated by the time they are created, they cannot request a pack size for the inputs. As such, I am fine with diagnostics being implemented only for Real scalar type.

So if by "issue with pack" you mean "make sure vert_contraction works with packs before using it in other diags", I think you can just move forward without waiting for such fix.

@mahf708
Copy link
Contributor Author

mahf708 commented Feb 26, 2025

I was thinking for non-diags purposes, we want to support that; some physics process may calculate these contractions...

@bartgol
Copy link
Contributor

bartgol commented Feb 26, 2025

Ah, sorry, then yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup code usability EAMxx PRs focused on capabilities for EAMxx
Projects
None yet
Development

No branches or pull requests

2 participants