Skip to content

Commit

Permalink
Consider delisted symbol if ticker_time is None
Browse files Browse the repository at this point in the history
  • Loading branch information
Herklos committed Jan 9, 2024
1 parent 8a7a7cf commit c76ca00
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.0.4] - 2024-01-09
### Fixed
- Consider delisted symbol if `ticker_time` is None

## [1.0.3] - 2024-01-08
### Fixed
- Add `None` check before restoring `best_triplet`
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<img src="illustration.jpeg" width="250px" height="250px" alt="Triangular illustration">
</p>

# Triangular Arbitrage by OctoBot [1.0.3](https://github.com/Drakkar-Software/Triangular-Arbitrage/blob/master/CHANGELOG.md)
# Triangular Arbitrage by OctoBot [1.0.4](https://github.com/Drakkar-Software/Triangular-Arbitrage/blob/master/CHANGELOG.md)
[![PyPI](https://img.shields.io/pypi/v/OctoBot-Triangular-Arbitrage.svg)](https://pypi.python.org/pypi/OctoBot-Triangular-Arbitrage/)
[![Dockerhub](https://img.shields.io/docker/pulls/drakkarsoftware/octobot-triangular-arbitrage.svg?logo=docker)](https://hub.docker.com/r/drakkarsoftware/octobot-triangular-arbitrage)

Expand Down
2 changes: 1 addition & 1 deletion triangular_arbitrage/__init__.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
PROJECT_NAME = "OctoBot-Triangular-Arbitrage"
VERSION = "1.0.3"
VERSION = "1.0.4"
2 changes: 1 addition & 1 deletion triangular_arbitrage/detector.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def get_symbol_from_key(key_symbol: str) -> symbols.Symbol:

def is_delisted_symbols(exchange_time, ticker, threshold = 1 * constants.DAYS_TO_SECONDS * constants.MSECONDS_TO_SECONDS) -> bool:
ticker_time = ticker['timestamp']
return not (exchange_time - ticker_time <= threshold)
return ticker_time is None or not (exchange_time - ticker_time <= threshold)

def get_last_prices(exchange_time, tickers, ignored_symbols):
return [
Expand Down

0 comments on commit c76ca00

Please sign in to comment.