Warn on string.Equals() with flags in setter?

[JohanLarsson]

namespace N
{
    using System;
    using System.ComponentModel;
    using System.Runtime.CompilerServices;

    public class C : INotifyPropertyChanged
    {
        private string p;

        public event PropertyChangedEventHandler PropertyChanged;

        public string P
        {
            get => this.p;
            set
            {
                if (string.Equals(value, this.p, StringComparison.Ordinal))
                {
                    return;
                }

                this.p = value;
                this.OnPropertyChanged();
            }
        }

        protected virtual void OnPropertyChanged([CallerMemberName] string propertyName = null)
        {
            this.PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));
        }
    }
}

Above is not very nice as the expectation is that the property gets the assigned value. /cc @jnm2

[jnm2]

I agree; even if the notification is skipped, setting should not be skipped unless you can prove that there would be no way to observe the difference.

[JohanLarsson]

Ok, adding analyzer then, can always be disabled. Has chances of catching bugs.