Skip to content

Survey Price Fetching and Display Logic in Market Modal #483

@temptemp3

Description

@temptemp3

Survey Price Fetching and Display Logic in Market Modal

Summary

Conduct a review of how asset pricing information is fetched, processed, and displayed within the market modal to ensure consistency, accuracy, and alignment with protocol oracle data.

Background

The market modal serves as one of the primary user interfaces for interacting with lending markets. Users rely on displayed prices when making decisions related to supplying, borrowing, repaying, withdrawing, and evaluating risk.

Recent investigations into oracle behavior, market synchronization, and price drift have highlighted the need to verify that market modal pricing is sourced correctly and presented consistently throughout the application.

Objectives

  • Document all price sources used by the market modal.
  • Verify alignment between displayed prices and protocol oracle values.
  • Identify any discrepancies between UI pricing and protocol pricing.
  • Review handling of stale, unavailable, or delayed price data.
  • Ensure users receive accurate and understandable pricing information.

Investigation Areas

Price Fetching

  • Identify all API endpoints and services used to obtain price data.
  • Determine whether prices originate from:
    • Oracle values
    • Market prices
    • Aggregated pricing services
    • Cached values
    • Derived calculations
  • Document fallback behavior when primary price sources fail.

Price Processing

  • Review any client-side transformations.
  • Review rounding and formatting logic.
  • Verify decimal handling across assets.
  • Confirm consistency between displayed and internally used values.

Market Modal Display

  • Review all locations where pricing information is shown.
  • Verify displayed prices match expected values.
  • Review display of:
    • Asset price
    • Position value
    • Borrow value
    • Supply value
    • Collateral value
    • Health factor related calculations
    • USD-equivalent balances

Consistency Review

  • Compare modal prices against:
    • Market list prices
    • Portfolio values
    • Oracle-reported values
    • Backend API responses
  • Identify any divergence between application views.

Error Handling

  • Review behavior when prices are unavailable.
  • Verify loading states.
  • Verify stale data handling.
  • Verify user-facing error messaging.

Deliverables

  • Documentation of current pricing data flow.
  • Mapping of data sources used within the modal.
  • List of identified inconsistencies or risks.
  • Recommendations for improvements or simplification.
  • Follow-up issues for any discovered defects.

Acceptance Criteria

  • All market modal price sources are documented.
  • Price fetch flow is fully understood and validated.
  • Displayed values are verified against expected data sources.
  • Any inconsistencies are documented.
  • Error and fallback behavior is reviewed.
  • Actionable recommendations are produced.

Notes

This survey should focus on both technical correctness and user experience. Particular attention should be paid to situations where displayed prices differ from oracle prices, market prices, or values used internally by protocol calculations, as these can create user confusion and support burden.

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationmarketsLending markets, parameters, listings

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions