Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more fonts #26

Open
GypsyDangerous opened this issue Aug 27, 2020 · 6 comments
Open

Add more fonts #26

GypsyDangerous opened this issue Aug 27, 2020 · 6 comments
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@GypsyDangerous
Copy link
Member

We would like to have as many font options as possible in the app. But we don't have the time to keep adding fonts to the css file that contains them all. We welcome any contributions of font imports from any font provider like google fonts.

if you would like to add a font to the css file just add it to this file and make a pull request. In your pull request make sure to specify the name of the font you are adding so we can add to the database as an option.

@GypsyDangerous GypsyDangerous added good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed labels Aug 27, 2020
@AlexARNcode
Copy link

Hi, are you looking for "soft" fonts (example: https://medium.muz.li/top-5-ui-fonts-for-website-mobile-apps-d78829e58f7e), or more "crazy" fonts?

@GypsyDangerous
Copy link
Member Author

@AlexARNcode pretty much anything, within reason. The "soft" fonts are preferred but since the user can select whatever they want to use a lot of "crazy" fonts fine, just not too crazy like wing-dings and stuff like that. A safe bet would be to contribute a font from google fonts. Using google fonts gives you about a 90% chance of the font being. We are going to try to accept as many fonts as possible but if they are too crazy we'll have to deny them.

@GypsyDangerous
Copy link
Member Author

@AlexARNcode did that help?

@mbeuil
Copy link
Contributor

mbeuil commented Oct 1, 2020

I've just added some font I like to use in #50 . I also saw that you import some font multiple times (like Noto Sans JP, Poppins, Source Sans Pro)

@GypsyDangerous
Copy link
Member Author

thanks for pointing that out. Feel free to make another pr removing the duplicate imports, if not I will do later

@mbeuil
Copy link
Contributor

mbeuil commented Oct 1, 2020

I'll do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants