Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interp(x, xp, fp) #91

Open
jecampagne opened this issue Apr 9, 2022 · 2 comments
Open

interp(x, xp, fp) #91

jecampagne opened this issue Apr 9, 2022 · 2 comments

Comments

@jecampagne
Copy link
Collaborator

Hi,
jax.numpy has an interp method since August 2020, with the same API, so I guess we can switch to this JAX implementation instead of https://github.com/DifferentiableUniverseInitiative/jax_cosmo/blob/master/jax_cosmo/scipy/interpolate.py
@jecampagne
Copy link
Collaborator Author

In def radial_comoving_distance ( background.py)

240:  a = np.atleast_1d(a)

is not useful using jnp.interp and more it prevents to make a grad.

@eelregit
Copy link
Contributor

Maybe asarray is enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eelregit @jecampagne