Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in cic_read #24

Open
Arne-Thomsen opened this issue Nov 21, 2024 · 0 comments
Open

Typo in cic_read #24

Arne-Thomsen opened this issue Nov 21, 2024 · 0 comments

Comments

@Arne-Thomsen
Copy link

neighboor_coords[..., 3]] * kernel).sum(axis=-1)

The return line

    return (mesh[neighboor_coords[..., 0], neighboor_coords[..., 1],
                 neighboor_coords[..., 3]] * kernel).sum(axis=-1)

should be

    return (mesh[neighboor_coords[..., 0], neighboor_coords[..., 1],
                 neighboor_coords[..., 2]] * kernel).sum(axis=-1)

but the behavior is identical because of JAX out-of-bounds indexing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant