Skip to content

Commit d6ec1a7

Browse files
fix androidtv subtitle off item language name (#465)
* fix androidtv subtitle off item language name and bump doris and rndv version * fix: bump rndv to fix tvos build issue --------- Co-authored-by: hailiang.song <[email protected]>
1 parent e96c612 commit d6ec1a7

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

android-exoplayer/src/main/java/com/brentvatne/exoplayer/VideoEventEmitter.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -410,7 +410,7 @@ void watchlistButtonClick() {
410410
void skipMarkerClick(SkipMarker skipMarker) {
411411
WritableMap map = Arguments.createMap();
412412
map.putString(EVENT_PROP_TYPE, skipMarker.skipMarkerType.name().toLowerCase());
413-
map.putDouble(EVENT_PROP_TARGET, (double)skipMarker.endTimeMs);
413+
map.putDouble(EVENT_PROP_TARGET, (double) skipMarker.endTimeMs);
414414
receiveEvent(EVENT_SKIP_MARKER, map);
415415
}
416416

@@ -419,8 +419,9 @@ void annotationsButtonClick() {
419419
}
420420

421421
void subtitleTrackChanged(String language) {
422+
String lang = "OFF".equalsIgnoreCase(language) ? "" : language;
422423
WritableMap map = Arguments.createMap();
423-
map.putString(EVENT_PROP_LANGUAGE, language);
424+
map.putString(EVENT_PROP_LANGUAGE, lang);
424425
receiveEvent(EVENT_SUBTITLE_TRACK_CHANGED, map);
425426
}
426427

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "react-native-video",
3-
"version": "7.12.16",
4-
"dorisAndroidVersion": "5.2.15-hotfix",
3+
"version": "7.12.17",
4+
"dorisAndroidVersion": "5.2.20",
55
"messagingAndroidVersion": "1.1.0",
66
"description": "A <Video /> element for react-native",
77
"main": "Video.tsx",
@@ -21,7 +21,7 @@
2121
"eslint-plugin-react": "3.16.1"
2222
},
2323
"dependencies": {
24-
"@dicetechnology/react-native-dice-video": "git+ssh://[email protected]/DiceTechnology/react-native-dice-video.git#7.3.7-hotfix-3",
24+
"@dicetechnology/react-native-dice-video": "git+ssh://[email protected]/DiceTechnology/react-native-dice-video.git#7.4.14",
2525
"@dicetechnology/dice-unity": "^2.26.3",
2626
"keymirror": "0.1.1",
2727
"prop-types": "^15.5.10"

0 commit comments

Comments
 (0)