Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing arm64 docker image #1196

Open
glensc opened this issue Dec 10, 2024 · 5 comments
Open

Missing arm64 docker image #1196

glensc opened this issue Dec 10, 2024 · 5 comments

Comments

@glensc
Copy link

glensc commented Dec 10, 2024

$ docker run --rm --name subliminal -v subliminal_cache:/usr/src/cache -v `pwd`:/app -w /app -it diaoulael/subliminal download -l en blah.avi
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
exec /usr/local/bin/subliminal: exec format error
@ptrcnull
Copy link
Collaborator

i suppose we could build those? i'm using subliminal on arm64 and it works just fine, though i'm not sure how to wire GH Actions to building cross-platform yet

@glensc
Copy link
Author

glensc commented Dec 10, 2024

it should be pretty straight forward to add docker image publishing from github workflow.

The existing Dockerfile doesn't seem to be specific to x64:

I can send a PR if there's no obvious reason pointed out why that would be rejected.

@glensc
Copy link
Author

glensc commented Dec 10, 2024

Current, local workaround, build the image locally:

docker build -t diaoulael/subliminal "https://github.com/Diaoul/subliminal.git#HEAD"

or build from git checkout:

git clone https://github.com/Diaoul/subliminal --depth 1
docker build -t diaoulael/subliminal subliminal/

@glensc
Copy link
Author

glensc commented Dec 10, 2024

Something not right yet

diff --git a/.dockerignore b/.dockerignore
index b77cc43..2547808 100644
--- a/.dockerignore
+++ b/.dockerignore
@@ -1,5 +1,4 @@
 # SCM
-.git/
 
 # Byte-compiled / optimized / DLL files
 __pycache__/
diff --git a/Dockerfile b/Dockerfile
index 60f3903..9ff7064 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -30,6 +30,7 @@ VOLUME /usr/src/cache
 
 COPY . /usr/src/app
 RUN python -m pip install -U pip
+RUN apk add git
 RUN python -m pip install .
 
 

had to make those local changes for build to succeed.

@glensc
Copy link
Author

glensc commented Dec 10, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants