-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing arm64 docker image #1196
Comments
i suppose we could build those? i'm using subliminal on arm64 and it works just fine, though i'm not sure how to wire GH Actions to building cross-platform yet |
it should be pretty straight forward to add docker image publishing from github workflow. The existing Dockerfile doesn't seem to be specific to x64: I can send a PR if there's no obvious reason pointed out why that would be rejected. |
Current, local workaround, build the image locally: docker build -t diaoulael/subliminal "https://github.com/Diaoul/subliminal.git#HEAD" or build from git checkout: git clone https://github.com/Diaoul/subliminal --depth 1
docker build -t diaoulael/subliminal subliminal/ |
Something not right yet diff --git a/.dockerignore b/.dockerignore
index b77cc43..2547808 100644
--- a/.dockerignore
+++ b/.dockerignore
@@ -1,5 +1,4 @@
# SCM
-.git/
# Byte-compiled / optimized / DLL files
__pycache__/
diff --git a/Dockerfile b/Dockerfile
index 60f3903..9ff7064 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -30,6 +30,7 @@ VOLUME /usr/src/cache
COPY . /usr/src/app
RUN python -m pip install -U pip
+RUN apk add git
RUN python -m pip install .
had to make those local changes for build to succeed. |
@ptrcnull It's pretty straight forward, and imho well documented I've using those actions in few projects |
The text was updated successfully, but these errors were encountered: