that will teach me to not copy code from stackoverflow without checking it thoroughly

devshgraphicsprogramming · devshgraphicsprogramming · commit f9cc17d2c986 · 2021-04-08T12:39:42.000+02:00
diff --git a/include/nbl/core/algorithm/radix_sort.h b/include/nbl/core/algorithm/radix_sort.h
@@ -34,7 +34,7 @@ struct KeyAdaptor
 };
 
 template<typename T>
-constexpr uint8_t find_msb(const T& a_variable)
+constexpr int8_t find_msb(const T& a_variable)
 {
     static_assert(std::is_unsigned<T>::value, "Variable must be unsigned");
 
@@ -44,9 +44,9 @@ constexpr uint8_t find_msb(const T& a_variable)
     for (uint8_t msb = number_of_bits - 1; msb >= 0; msb--)
     {
         if (variable_bitset[msb] == 1)
-            return msb + 1;
+            return msb;
     }        
-    return 0;
+    return -1;
 }
 
 template<size_t key_bit_count, typename histogram_t>

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ struct KeyAdaptor`
`34`	`34`	`};`
`35`	`35`
`36`	`36`	`template<typename T>`
`37`		`-constexpr uint8_t find_msb(const T& a_variable)`
	`37`	`+constexpr int8_t find_msb(const T& a_variable)`
`38`	`38`	`{`
`39`	`39`	`static_assert(std::is_unsigned<T>::value, "Variable must be unsigned");`
`40`	`40`
`@@ -44,9 +44,9 @@ constexpr uint8_t find_msb(const T& a_variable)`
`44`	`44`	`for (uint8_t msb = number_of_bits - 1; msb >= 0; msb--)`
`45`	`45`	`{`
`46`	`46`	`if (variable_bitset[msb] == 1)`
`47`		`- return msb + 1;`
	`47`	`+ return msb;`
`48`	`48`	`}`
`49`		`- return 0;`
	`49`	`+ return -1;`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`template<size_t key_bit_count, typename histogram_t>`