fix zlib issue reported by Karim which CI and my PC failed to spot and gave false positive, update 3rdparty/CMakeLists.txt and add cmake/FindZLIB.cmake

linker entry "zlibstatic" was generated but somehow CI didn't fail nor my PC, would need to fire verbose linker and I would find out it took it from different location, most probably - irrelevant anymore

Author: AnastaZIuk

3rdparty/CMakeLists.txt

@@ -13,6 +13,22 @@ set(BUILD_TESTING OFF)
 option(NBL_FORCE_RELEASE_3RDPARTY "Force map 3rdaprty's configuration regardless Nabla configuration to Release" OFF)
 option(NBL_FORCE_RELWITHDEBINFO_3RDPARTY "Force map 3rdaprty's configuration regardless Nabla configuration to RelWithDebInfo" OFF)
 
+# zlib
+set(ZLIB_BUILD_SHARED OFF)
+set(ZLIB_BUILD_STATIC ON)
+set(ZLIB_INSTALL OFF)
+set(ZLIB_BUILD_TESTING OFF)
+set(ZLIB_BUILD_MINIZIP OFF)
+add_subdirectory(zlib zlib EXCLUDE_FROM_ALL)
+get_target_property(ZLIB_BINARY_DIR zlibstatic "BINARY_DIR")
+set_target_properties(zlibstatic PROPERTIES 
+	ARCHIVE_OUTPUT_DIRECTORY $<1:${ZLIB_BINARY_DIR}>
+	DEBUG_POSTFIX "d"
+	RELWITHDEBINFO_POSTFIX "rwdi"
+	OUTPUT_NAME zlibstatic
+)
+add_library(ZLIB::ZLIB ALIAS zlibstatic) # trick projects which want to use it via alias
+
 # nlohmann_json
 set(JSON_BuildTests OFF)
 add_subdirectory(nlohmann_json nlohmann_json EXCLUDE_FROM_ALL)
@@ -81,21 +97,6 @@ endif()
 # boost
 add_subdirectory(boost boost EXCLUDE_FROM_ALL)
 
-# zlib
-set(ZLIB_BUILD_SHARED OFF)
-set(ZLIB_BUILD_STATIC ON)
-set(ZLIB_INSTALL OFF)
-set(ZLIB_BUILD_TESTING OFF)
-set(ZLIB_BUILD_MINIZIP OFF)
-add_subdirectory(zlib zlib EXCLUDE_FROM_ALL)
-add_library(ZLIB::ZLIB ALIAS zlibstatic) # trick projects which want to use it
-get_target_property(ZLIB_BINARY_DIR zlibstatic "BINARY_DIR")
-set_target_properties(zlibstatic PROPERTIES 
-	ARCHIVE_OUTPUT_DIRECTORY $<1:${ZLIB_BINARY_DIR}>
-	DEBUG_POSTFIX "d"
-	OUTPUT_NAME zlibstatic
-)
-
 set(SPIRV_HEADERS_SKIP_INSTALL ON CACHE INTERNAL "Skip SPIRV-Headers install")
 set(SPIRV_HEADERS_SKIP_EXAMPLES ON CACHE INTERNAL "Skip SPIRV-Headers examples")
 add_subdirectory("${DXC_SPIRV_HEADERS_DIR}" SPIRV-Headers EXCLUDE_FROM_ALL)

cmake/FindZLIB.cmake

@@ -0,0 +1,7 @@
+if(NOT TARGET ZLIB::ZLIB)
+	message(FATAL_ERROR "define ZLIB::ZLIB target!")
+endif()
+
+set(ZLIB_FOUND TRUE)
+set(ZLIB_LIBRARY ZLIB::ZLIB)
+set(ZLIB_INCLUDE_DIR "${THIRD_PARTY_SOURCE_DIR}/zlib;${THIRD_PARTY_BINARY_DIR}/zlib")