Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added solving sudoku using backtracking sudoku snippet #18

Merged
merged 7 commits into from
Oct 17, 2020
Merged

Conversation

dwij2212
Copy link
Contributor

@dwij2212 dwij2212 commented Oct 12, 2020

Solving sudoku using Backtracking challenge snippet

Added the code snippet for solving a sudoku using backtracking. I have given a short description of the algorithm and links to various sources for those interested in learning more about backtracking.

Fixes: #13

Type of change

Please delete options that are not relevant. (including this line)

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generates no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@sakshamarora1
Copy link
Contributor

sakshamarora1 commented Oct 13, 2020

@dwij2212 Thanks for creating a great PR! Everything looks great! Can you add an example in the form of input and output. As it will provide more info to others viewing it in the future. :D

Also can you edit the name of the file to contain sudoku.

@dwij2212
Copy link
Contributor Author

I added a driver code snippet.

Copy link
Contributor

@sakshamarora1 sakshamarora1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwij2212 Great stuff with detailed comments! Just a few things to take care of. :D

challenges/Sudoku-BackTracking.md Outdated Show resolved Hide resolved
challenges/Sudoku-BackTracking.md Outdated Show resolved Hide resolved
challenges/Sudoku-BackTracking.md Outdated Show resolved Hide resolved
challenges/Sudoku-BackTracking.md Outdated Show resolved Hide resolved
challenges/Sudoku-BackTracking.md Outdated Show resolved Hide resolved
challenges/Sudoku-BackTracking.md Outdated Show resolved Hide resolved
challenges/Sudoku-BackTracking.md Outdated Show resolved Hide resolved
challenges/Sudoku-BackTracking.md Outdated Show resolved Hide resolved
challenges/Sudoku-BackTracking.md Outdated Show resolved Hide resolved
challenges/Sudoku-BackTracking.md Outdated Show resolved Hide resolved
@kaustubhgupta
Copy link
Contributor

kaustubhgupta commented Oct 14, 2020

@dwij2212 Please make the suggested changes before requesting a review

@dwij2212
Copy link
Contributor Author

dwij2212 commented Oct 14, 2020

@kaustubhgupta I couldn't quite get what you are suggesting when you say merge it into one doc string. Please elaborate on it.

Copy link
Contributor

@sakshamarora1 sakshamarora1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

challenges/Sudoku-BackTracking-C++.md Outdated Show resolved Hide resolved
challenges/Sudoku-BackTracking-C++.md Outdated Show resolved Hide resolved
@kaustubhgupta kaustubhgupta merged commit 65ec95d into Developer-Students-Club-MAIT:master Oct 17, 2020
@kaustubhgupta kaustubhgupta added hacktoberfest hacktoberfest-accepted The PR will be counted towards hacktobetfest snippet A cool code snippet labels Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted The PR will be counted towards hacktobetfest snippet A cool code snippet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sudoku Solver (Backtracking)
3 participants