Skip to content

Commit de6976f

Browse files
chore(web): apply PR review suggestions for test setup
1 parent 109b602 commit de6976f

5 files changed

Lines changed: 9 additions & 4 deletions

File tree

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
export type PageData = {
2+
profile?: { displayName: string; avatarUrl: string };
3+
error?: string;
4+
};

apps/web/src/routes/u/[username]/+page.svelte

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
<script lang="ts">
2-
export let data: { profile?: { displayName: string; avatarUrl: string }; error?: string };
2+
import type { PageData } from './$types';
3+
export let data: PageData;
34
</script>
45

56
{#if data?.error}

apps/web/src/routes/u/[username]/+page.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import '@testing-library/jest-dom/vitest';
1+
22
import { render, screen } from '@testing-library/svelte';
33
import { describe, it, expect } from 'vitest';
44
import Page from './+page.svelte';

apps/web/vitest-setup.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
import '@testing-library/jest-dom';
1+
import '@testing-library/jest-dom/vitest';

apps/web/vitest.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@ export default defineConfig({
1010
globals: true,
1111
},
1212
resolve: {
13-
conditions: ['mode=test', 'browser'],
13+
conditions: ['browser', 'svelte'],
1414
},
1515
});

0 commit comments

Comments
 (0)