fix(cards): address review feedback

Author: udaycodespace

apps/backend/src/__tests__/cards.test.ts

@@ -1,5 +1,6 @@
 import { describe, it, expect, beforeEach, vi } from 'vitest';
-import Fastify from 'fastify';
+import Fastify, { FastifyRequest } from 'fastify';
+import { Prisma } from '@prisma/client';
 import { cardRoutes } from '../routes/cards.js';
 
 const USER_ID = 'user-123';
@@ -45,14 +46,14 @@ const mockPrisma = {
 // against the same mock client, preserving existing per-operation mocks.
 function wireTransaction() {
   mockPrisma.$transaction.mockImplementation(
-    async (callback: (tx: typeof mockPrisma) => Promise<unknown>, options?: any) => callback(mockPrisma),
+    async (callback: (tx: typeof mockPrisma) => Promise<unknown>, options?: unknown) => callback(mockPrisma),
   );
 }
 
 async function buildApp() {
   const app = Fastify({ logger: false });
   app.decorate('prisma', mockPrisma);
-  app.decorate('authenticate', async (request: any) => {
+  app.decorate('authenticate', async (request: FastifyRequest & { user?: { id: string } }) => {
     request.user = { id: USER_ID };
   });
   app.register(cardRoutes, { prefix: '/api/cards' });
@@ -204,8 +205,8 @@ describe('POST /api/cards — link ownership validation', () => {
 
     // First attempt fails with P2034 (serialization conflict)
     // Second attempt succeeds
-    const error = new Error('Serialization failure');
-    (error as any).code = 'P2034';
+    const error = new Error('Serialization failure') as Error & { code: string };
+    error.code = 'P2034';
 
     // We mock $transaction to fail once, then succeed
     mockPrisma.$transaction

apps/backend/src/services/cardService.ts

@@ -1,15 +1,17 @@
 import type { FastifyInstance } from 'fastify'
-import type { Prisma } from '@prisma/client'
+
+
+type RawCard = { id: string, title: string, isDefault: boolean, cardLinks: { platformLink: unknown }[] };
 
 export async function listCards(app: FastifyInstance, userId: string) {
   const cards = await app.prisma.card.findMany({
     where: { userId },
     take: 50,
     include: { cardLinks: { include: { platformLink: true }, orderBy: { displayOrder: 'asc' } } },
     orderBy: { createdAt: 'asc' },
-  })
+  }) as unknown as RawCard[];
 
-  return cards.map((card: any) => ({ id: card.id, title: card.title, isDefault: card.isDefault, links: card.cardLinks.map((cl: any) => cl.platformLink) }))
+  return cards.map((card) => ({ id: card.id, title: card.title, isDefault: card.isDefault, links: card.cardLinks.map((cl) => cl.platformLink) }))
 }
 
 export async function createCard(app: FastifyInstance, userId: string, body: { title: string; linkIds: string[] }) {
@@ -34,12 +36,21 @@ export async function createCard(app: FastifyInstance, userId: string, body: { t
           include: { cardLinks: { include: { platformLink: true }, orderBy: { displayOrder: 'asc' } } },
         })
       }, {
-        isolationLevel: 'Serializable' as Prisma.TransactionIsolationLevel
-      })
-
-      return { id: card.id, title: card.title, isDefault: card.isDefault, links: card.cardLinks.map((cl: any) => cl.platformLink) }
-    } catch (error: any) {
-      if (error.code === 'P2034' && attempt < MAX_RETRIES) continue;
+        isolationLevel: 'Serializable'
+      }) as unknown as RawCard;
+
+      return { id: card.id, title: card.title, isDefault: card.isDefault, links: card.cardLinks.map((cl) => cl.platformLink) }
+    } catch (error: unknown) {
+      if (
+        typeof error === 'object' && 
+        error !== null && 
+        'code' in error && 
+        (error as { code: string }).code === 'P2034' && 
+        attempt < MAX_RETRIES
+      ) {
+        continue;
+      }
+      app.log.error(error);
       throw error;
     }
   }
@@ -68,8 +79,9 @@ export async function updateCard(app: FastifyInstance, userId: string, id: strin
     })
   }
 
-  const updated = await app.prisma.card.findUnique({ where: { id }, include: { cardLinks: { include: { platformLink: true }, orderBy: { displayOrder: 'asc' } } } })
-  return { id: updated!.id, title: updated!.title, isDefault: updated!.isDefault, links: updated!.cardLinks.map((cl: any) => cl.platformLink) }
+  const updated = (await app.prisma.card.findUnique({ where: { id }, include: { cardLinks: { include: { platformLink: true }, orderBy: { displayOrder: 'asc' } } } })) as unknown as RawCard | null;
+  if (!updated) return null;
+  return { id: updated.id, title: updated.title, isDefault: updated.isDefault, links: updated.cardLinks.map((cl) => cl.platformLink) }
 }
 
 export async function deleteCard(app: FastifyInstance, userId: string, id: string) {