fix(ci): fix typecheck file-args bug and pre-existing type/lint errors

Root cause: `pnpm typecheck $backendFiles` passed explicit file paths to
`tsc --noEmit`, which causes TypeScript to ignore tsconfig.json entirely.
Without tsconfig settings (esModuleInterop, module: ESNext, etc.), tsc
fails with dozens of errors. The step had outcome='failure' despite showing
✅ in the UI (continue-on-error changes conclusion but not outcome), so
"Fail backend if checks failed" correctly triggered exit 1.

Fixes:
- ci.yml: run `prisma generate` after install; drop file args from typecheck
- package.json: add postinstall to always generate Prisma client
- app.test.ts: set JWT_SECRET + ENCRYPTION_KEY so validateEnv() passes
- validateEnv.test.ts: add null to process.exit mock param type
- cards.test.ts: cast mockPrisma as any for app.decorate
- profiles.test.ts: remove Pick<PrismaClient> annotation that hid mock types
- connect.ts / follow.ts: fix logger format, unused vars, import order

Note: pull_request_target uses base branch workflow, so this PR's CI run
uses the pre-fix workflow. These changes take effect for future PRs after
merge to main.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: Ridanshi

.github/workflows/ci.yml

@@ -61,6 +61,9 @@ jobs:
       - name: Install backend dependencies
         run: npm --prefix apps/backend install
 
+      - name: Generate Prisma client
+        run: cd apps/backend && pnpm prisma generate
+
       - name: Backend lint
         id: backend_lint
         continue-on-error: true                         

apps/backend/package.json

@@ -4,6 +4,7 @@
   "private": true,
   "type": "module",
   "scripts": {
+    "postinstall": "prisma generate",
     "dev": "tsx watch src/server.ts",
     "build": "tsc",
     "start": "node dist/server.js",

apps/backend/src/__tests__/cards.test.ts

@@ -1,4 +1,4 @@
-import Fastify, { type FastifyInstance, type FastifyRequest } from 'fastify';
+import Fastify, { type FastifyInstance } from 'fastify';
 import { describe, it, expect, beforeEach, vi } from 'vitest';
 
 import { cardRoutes } from '../routes/cards.js';
@@ -53,10 +53,6 @@ function wireTransaction(): void {
 }
 
 async function buildApp(): Promise<FastifyInstance> {
-  const app = Fastify({ logger: false });
-  app.decorate('prisma', mockPrisma);
-  app.decorate('authenticate', async (request: FastifyRequest & { user?: { id: string } }) => {
-async function buildApp():Promise<FastifyInstance> {
   const app = Fastify({ logger: false });
   app.decorate('prisma', mockPrisma as unknown as PrismaClient);
   app.decorate('authenticate', async (request: any) => {

apps/backend/src/routes/connect.ts

@@ -1,7 +1,10 @@
-import type { FastifyInstance, FastifyRequest, FastifyReply } from 'fastify';
-import { randomBytes } from 'crypto';
+import { randomBytes } from 'node:crypto';
+
 import { encrypt } from '../utils/encryption.js';
 
+import type { FastifyInstance, FastifyRequest, FastifyReply } from 'fastify';
+
+
 const GITHUB_AUTH_URL = 'https://github.com/login/oauth/authorize';
 const GITHUB_TOKEN_URL = 'https://github.com/login/oauth/access_token';
 
@@ -30,9 +33,9 @@ export async function connectRoutes(app: FastifyInstance) {
       const server = request.server as any;
       if (typeof server?.authenticate === 'function') { await server.authenticate(request, reply); return }
       if (typeof (app as any).authenticate === 'function') { await (app as any).authenticate(request, reply); return }
-      try { await request.jwtVerify() } catch (e) { reply.status(401).send({ error: 'Unauthorized' }) }
+      try { await request.jwtVerify() } catch (_e) { reply.status(401).send({ error: 'Unauthorized' }) }
     }],
-  }, async (request: FastifyRequest, reply: FastifyReply) => {
+  }, async (request: FastifyRequest, _reply: FastifyReply) => {
     const userId = (request.user as any).id;
 
     const tokens = await app.prisma.oAuthToken.findMany({
@@ -50,7 +53,7 @@ export async function connectRoutes(app: FastifyInstance) {
       const server = request.server as any;
       if (typeof server?.authenticate === 'function') { await server.authenticate(request, reply); return }
       if (typeof (app as any).authenticate === 'function') { await (app as any).authenticate(request, reply); return }
-      try { await request.jwtVerify() } catch (e) { reply.status(401).send({ error: 'Unauthorized' }) }
+      try { await request.jwtVerify() } catch (_e) { reply.status(401).send({ error: 'Unauthorized' }) }
     }],
   }, async (request: FastifyRequest, reply: FastifyReply) => {
     const userId = (request.user as any).id;
@@ -102,7 +105,7 @@ export async function connectRoutes(app: FastifyInstance) {
       }
 
       // Consume the nonce -- one-time use only (if redis configured)
-      if (app.redis) await app.redis.del(`oauth:nonce:${decodedState.nonce}`);
+      if (app.redis) {await app.redis.del(`oauth:nonce:${decodedState.nonce}`);}
 
       const userId = decodedState.userId;
 
@@ -124,7 +127,7 @@ export async function connectRoutes(app: FastifyInstance) {
       const tokenData = (await tokenRes.json()) as any;
 
       if (tokenData.error) {
-        app.log.error('GitHub connect token error:', tokenData);
+        app.log.error({ tokenData }, 'GitHub connect token error');
         return reply.redirect(`${process.env.PUBLIC_APP_URL}/settings?error=connect_failed`);
       }
 
@@ -175,7 +178,7 @@ export async function connectRoutes(app: FastifyInstance) {
       const server = request.server as any;
       if (typeof server?.authenticate === 'function') { await server.authenticate(request, reply); return }
       if (typeof (app as any).authenticate === 'function') { await (app as any).authenticate(request, reply); return }
-      try { await request.jwtVerify() } catch (e) { reply.status(401).send({ error: 'Unauthorized' }) }
+      try { await request.jwtVerify() } catch (_e) { reply.status(401).send({ error: 'Unauthorized' }) }
     }],
   }, async (request: FastifyRequest<{ Params: { platform: string } }>, reply: FastifyReply) => {
     const userId = (request.user as any).id;
@@ -196,7 +199,7 @@ export async function connectRoutes(app: FastifyInstance) {
         },
       });
       return { success: true };
-    } catch (error) {
+    } catch (_error) {
       return reply.status(404).send({ error: 'Connection not found' });
     }
   });

apps/backend/src/routes/follow.ts

@@ -1,15 +1,17 @@
-import type { FastifyInstance, FastifyRequest, FastifyReply } from 'fastify';
+import { getPlatform, getProfileUrl, getWebViewUrl } from '@devcard/shared';
+
 import { decrypt } from '../utils/encryption.js';
 import { getErrorMessage } from '../utils/error.util.js';
-import { getPlatform, getProfileUrl, getWebViewUrl } from '@devcard/shared';
 import { followLogSchema } from '../validations/follow.validation.js';
 
+import type { FastifyInstance, FastifyRequest, FastifyReply } from 'fastify';
+
 export async function followRoutes(app: FastifyInstance) {
     app.addHook('preHandler', async (request, reply) => {
       const server = request.server as any;
       if (typeof server?.authenticate === 'function') { await server.authenticate(request, reply); return }
       if (typeof (app as any).authenticate === 'function') { await (app as any).authenticate(request, reply); return }
-      try { const payload = await request.jwtVerify(); if (payload) (request as any).user = payload; } catch (e) { reply.status(401).send({ error: 'Unauthorized' }) }
+      try { const payload = await request.jwtVerify(); if (payload) { (request as any).user = payload; } } catch (_e) { reply.status(401).send({ error: 'Unauthorized' }) }
     });
 
   // ─── Follow via API (Layer 1) ───
@@ -138,7 +140,7 @@ export async function followRoutes(app: FastifyInstance) {
       });
       return reply.send({ status: 'success', logId: log.id });
     } catch (error: any) {
-      app.log.error('Failed to log follow:', error);
+      app.log.error({ error }, 'Failed to log follow');
       return reply.status(500).send({ error: 'Failed to log follow event' });
     }
   });