fix(connect): hard-fail OAuth callback when Redis unavailable #71
hariom888ci.yml
on: pull_request_target
Annotations
24 errors and 1 warning
|
backend-ci
Process completed with exit code 1.
|
|
backend-ci
Property 'PrismaClientKnownRequestError' does not exist on type 'typeof Prisma'.
|
|
backend-ci
Parameter 'link' implicitly has an 'any' type.
|
|
backend-ci
Parameter 'm' implicitly has an 'any' type.
|
|
backend-ci
Parameter 'u' implicitly has an 'any' type.
|
|
backend-ci
Parameter 'tm' implicitly has an 'any' type.
|
|
backend-ci
'error' is of type 'unknown'.
|
|
backend-ci
Property 'PrismaClientKnownRequestError' does not exist on type 'typeof Prisma'.
|
|
backend-ci
Parameter 'tx' implicitly has an 'any' type.
|
|
backend-ci
Module '"@prisma/client"' has no exported member 'TeamRole'.
|
|
backend-ci
Module '"@prisma/client"' has no exported member 'TeamRole'.
|
|
backend-ci
Process completed with exit code 1.
|
|
src/__tests__/connect.test.ts > GET /api/connect/github/callback — CSRF nonce enforcement > consumes the nonce exactly once — replay of the same state is rejected:
apps/backend/src/__tests__/connect.test.ts#L151
AssertionError: expected 'https://app.devcard.test/settings?err…' to contain 'connected=github'
Expected: "connected=github"
Received: "https://app.devcard.test/settings?error=server_error"
❯ src/__tests__/connect.test.ts:151:36
|
|
src/__tests__/connect.test.ts > GET /api/connect/github/callback — CSRF nonce enforcement > completes the OAuth flow and stores the token when nonce is valid:
apps/backend/src/__tests__/connect.test.ts#L133
AssertionError: expected 'https://app.devcard.test/settings?err…' to contain 'connected=github'
Expected: "connected=github"
Received: "https://app.devcard.test/settings?error=server_error"
❯ src/__tests__/connect.test.ts:133:34
|
|
backend-ci:
apps/backend/src/routes/connect.ts#L53
'e' is defined but never used. Allowed unused caught errors must match /^_/u
|
|
backend-ci:
apps/backend/src/routes/connect.ts#L35
'reply' is defined but never used. Allowed unused args must match /^_/u
|
|
backend-ci:
apps/backend/src/routes/connect.ts#L33
'e' is defined but never used. Allowed unused caught errors must match /^_/u
|
|
backend-ci:
apps/backend/src/routes/connect.ts#L2
Prefer `node:crypto` over `crypto`
|
|
backend-ci:
apps/backend/src/routes/connect.ts#L2
There should be at least one empty line between import groups
|
|
backend-ci:
apps/backend/src/routes/connect.ts#L1
`fastify` type import should occur after import of `../utils/encryption.js`
|
|
backend-ci:
apps/backend/src/routes/connect.ts#L1
There should be at least one empty line between import groups
|
|
backend-ci:
apps/backend/src/__tests__/connect.test.ts#L4
`../routes/connect.js` import should occur before type import of `@prisma/client`
|
|
backend-ci:
apps/backend/src/__tests__/connect.test.ts#L3
There should be at least one empty line between import groups
|
|
backend-ci:
apps/backend/src/__tests__/connect.test.ts#L2
There should be at least one empty line between import groups
|
|
backend-ci:
apps/backend/src/routes/connect.ts#L25
Missing return type on function
|