Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create code guidelines for contributions #76

Open
GarthDB opened this issue Dec 8, 2013 · 9 comments
Open

Create code guidelines for contributions #76

GarthDB opened this issue Dec 8, 2013 · 9 comments

Comments

@GarthDB
Copy link
Member

GarthDB commented Dec 8, 2013

From something @terracomma mentioned in another issue.

@GarthDB
Copy link
Member Author

GarthDB commented Dec 8, 2013

Just some initial thoughts.

All custom pages need to:

@Moodycomputer
Copy link

I've never used schema.org before. What are the advantages of that vs carefully chosen tags?

@GarthDB
Copy link
Member Author

GarthDB commented Dec 8, 2013

You can apply it to any tags as attributes. It just is more semantic than HTML alone and search engines use it to better understand the structure of a website.

@Moodycomputer
Copy link

Sounds good, I'll start reading up on it.

@GarthDB
Copy link
Member Author

GarthDB commented Dec 8, 2013

@terracomma good place to start https://support.google.com/webmasters/answer/99170?hl=en

@Moodycomputer
Copy link

We should probably declare our browser support too. I suggest current -2 for Chrome, FF and Safari.

@GarthDB
Copy link
Member Author

GarthDB commented Dec 17, 2013

good call
I don't have ie to test
but we would accept contributions on it.

@GarthDB
Copy link
Member Author

GarthDB commented Dec 17, 2013

I don't mind being a bit more bleeding edge.

@Moodycomputer
Copy link

I agree. If someone wants to IE fix all our stuff, by all means we'll accept it. But I would love to not write it myself.

@GarthDB GarthDB added the ready label Feb 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants