From 3172cf62363bd4440139557dce20b9d57b8fbd4b Mon Sep 17 00:00:00 2001
From: Sahiba Mittal <sahiba.mittal@citi.com>
Date: Fri, 24 Jan 2025 17:12:55 +0000
Subject: [PATCH 1/2] fix: disable create button until version is provided

Co-Authored-By: Idris Gadi <85882535+idrisgit@users.noreply.github.com>
---
 .../projects/ProjectAddVersionModal.vue       | 31 ++++++++++++++++---
 1 file changed, 27 insertions(+), 4 deletions(-)

diff --git a/src/views/portfolio/projects/ProjectAddVersionModal.vue b/src/views/portfolio/projects/ProjectAddVersionModal.vue
index cd31ac73..1fcbde6c 100644
--- a/src/views/portfolio/projects/ProjectAddVersionModal.vue
+++ b/src/views/portfolio/projects/ProjectAddVersionModal.vue
@@ -15,7 +15,13 @@
           label-for="input-1"
           label-class="required"
         >
-          <b-form-input id="input-1" v-model="version" class="required" trim />
+        <b-form-input
+            id="input-1"
+            v-model="version"
+            class="required"
+            trim
+            required
+          />
         </b-form-group>
       </b-col>
       <b-col cols="auto">
@@ -109,9 +115,13 @@
       <b-button size="md" variant="secondary" @click="cancel()">{{
         $t('message.cancel')
       }}</b-button>
-      <b-button size="md" variant="primary" @click="createVersion()">{{
-        $t('message.create')
-      }}</b-button>
+      <b-button
+        size="md"
+        variant="primary"
+        :disabled="isSubmitButtonDisabled"
+        @click="createVersion()"
+        >{{ $t('message.create') }}</b-button
+      >
     </template>
   </b-modal>
 </template>
@@ -138,6 +148,19 @@ export default {
       makeCloneLatest: false,
     };
   },
+  computed: {
+    isSubmitButtonDisabled() {
+      const versionInputValue = this.version;
+      if (versionInputValue) {
+        /**
+         * * ideally we would apply the check with the input value trimmed, however, since we are already using 'trim' prop on the input value.
+         * * trimming the value here is not required.
+         */
+        return versionInputValue.length === 0;
+      }
+      return true;
+    },
+  },
   methods: {
     createVersion: function () {
       let url = `${this.$api.BASE_URL}/${this.$api.URL_PROJECT}/clone`;

From d86baa9d772a42f126d8f2d8c21ac94ae92cf4f1 Mon Sep 17 00:00:00 2001
From: Sahiba Mittal <sahiba.mittal@citi.com>
Date: Fri, 24 Jan 2025 17:23:00 +0000
Subject: [PATCH 2/2] Update ProjectAddVersionModal.vue

---
 src/views/portfolio/projects/ProjectAddVersionModal.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/views/portfolio/projects/ProjectAddVersionModal.vue b/src/views/portfolio/projects/ProjectAddVersionModal.vue
index 1fcbde6c..aeed9d5a 100644
--- a/src/views/portfolio/projects/ProjectAddVersionModal.vue
+++ b/src/views/portfolio/projects/ProjectAddVersionModal.vue
@@ -15,7 +15,7 @@
           label-for="input-1"
           label-class="required"
         >
-        <b-form-input
+          <b-form-input
             id="input-1"
             v-model="version"
             class="required"