Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slack][Membership Command] Use static selects for MembershipOptions, TrainableEquipment #42

Open
chungl opened this issue Jan 10, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@chungl
Copy link
Collaborator

chungl commented Jan 10, 2024

We should use static selects in our Slack modals rather than external selects whenever possible. Obvious candidates are the initial MembershipOptionsModal and the equipment list in EquipmentAuthorization.

External selects require slack to send a network request to webhooks to fetch the list of options, and are useful for lists that may change or are too large to prepopulate. However, this introduces noticeable latency to the modal as the user has to wait for select menus to populate. The static select element allows us to send the options as part of the view update, eliminating this round trip and improving UX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant