Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Django 1.11 (or 2.2) #94

Closed
chris48s opened this issue Jan 4, 2018 · 2 comments
Closed

Upgrade to Django 1.11 (or 2.2) #94

chris48s opened this issue Jan 4, 2018 · 2 comments

Comments

@chris48s
Copy link
Member

chris48s commented Jan 4, 2018

Django 1.10 is now unsupported and no longer receives security patches.

@chris48s chris48s changed the title Upgrade to Django 1.11 Upgrade to Django 1.11 (or 2.2) Aug 23, 2019
@chris48s
Copy link
Member Author

chris48s commented Aug 23, 2019

Had a bit of a poke at this today. This repo is hard to work on for several reasons:

  • There is a lot of code here that isn't used anymore/never really went anywhere. There's a lot of stuff throwing errors that may or may not actually be used, or I'm not really sure if it works/we care about it.
  • There aren't many tests
  • We're relying on a number of outdated/unmaintained dependencies.

One bit of work that needs doing is upgrading our hermes fork, so I've submitted DemocracyClub/django-hermes#4 to deal with that.

A blocker for django 2 is that we rely on https://github.com/klen/django_markdown which is now unmaintained: klen/django_markdown#81 To get to 2.2 we need to get rid of that dependency (or fork it, I guess), but I think we could move to 1.11 with this version. That might be more work on the hermes fork tbh. I'm slightly unclear which bits of the site are using which markdown parsers at this point (naturally we depend on multiple different markdown parsers).

I think the first thing to deal with though is to get rid of a bunch of stuff we don't need to we don't just spend time on a goose chase over stuff that doesn't matter, or trying to "fix" stuff that doesn't work anyway. For example, today I learned the DC corp site has an "api" 😮
https://democracyclub.org.uk/research/
https://democracyclub.org.uk/research/stats

@symroe
Copy link
Member

symroe commented Apr 29, 2020

As of today, i've removed a load of old code that's unused.

This makes things a little easier, but some of the initial issues remain.

@symroe symroe closed this as completed Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants