https://github.com/DeepX-inc/machina/blob/caf2e51859e764876963f8a24982607c0774e3b2/example/run_sac.py#L60-L61 max_ent params in the example seems not used. https://github.com/DeepX-inc/machina/blob/caf2e51859e764876963f8a24982607c0774e3b2/machina/algos/sac.py#L3 Furthermore, algo/sac.py refers to https://arxiv.org/pdf/1801.01290.pdf as a reference of algorithm but the algorithm uses temperature adjustment technique not used in the paper. Probably adding https://arxiv.org/pdf/1812.05905.pdf is better. Thanks.
machina/example/run_sac.py
Lines 60 to 61 in caf2e51
max_ent params in the example seems not used.
machina/machina/algos/sac.py
Line 3 in caf2e51
Furthermore, algo/sac.py refers to https://arxiv.org/pdf/1801.01290.pdf as a reference of algorithm but the algorithm uses temperature adjustment technique not used in the paper. Probably adding https://arxiv.org/pdf/1812.05905.pdf is better.
Thanks.