Adapt to https://github.com/rocq-prover/rocq/pull/17876 #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
@bcpierce00 We might want to replicate #15 and this PR to the upstream, and document the overlay process in the Rocq repo. |
proux01
added a commit
to herbelin/github-coq
that referenced
this pull request
Jun 27, 2025
Until DeepSpec/sf#16 can get in / the process for overlays there can be documented.
proux01
added a commit
to herbelin/github-coq
that referenced
this pull request
Jun 27, 2025
Until DeepSpec/sf#16 can get in / the process for overlays there can be documented.
proux01
added a commit
to herbelin/github-coq
that referenced
this pull request
Jul 3, 2025
Until DeepSpec/sf#16 can get in / the process for overlays there can be documented.
proux01
added a commit
to herbelin/github-coq
that referenced
this pull request
Jul 3, 2025
Until DeepSpec/sf#16 can get in / the process for overlays there can be documented.
proux01
added a commit
to herbelin/github-coq
that referenced
this pull request
Jul 4, 2025
Until DeepSpec/sf#16 can get in / the process for overlays there can be documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt to rocq-prover/rocq#17876
I have some vague remembrance that I shouldn't PR on this branch but we don't have any doc in https://github.com/rocq-prover/rocq/blob/336fc39aa6fdd327056a0839e172551641fb6c4d/dev/ci/ci-basic-overlay.sh#L456-L460
These notations are already reserved in Corelib and shouldn't be reserved again.
@bcpierce00, @liyishuai can I let you sort this out? Otherwise, no worries, I'll just temporarily disactivate SF in Rocq CI until this can be fixed.