-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Component Code to Registry Folder #26
Comments
Could you please elaborate on this? Should we just move the Component from src/components/DemoComponents/...tsx to the registry folder src/registry/...tsx folder and Update the imports? |
hi @J-B-Mugundh current problem is that we are hardcoding the component code in component.mdx file. But if try to look at |
What u basically mean is to put the components (example in screenshot) into registry folder and import them as code? While I tried it by creating a .tsx file in registry folder, i couldn't return the code inside the file. It was only possible to return a response value. Please find the following snips for better understanding. However, this didn't help me in displaying the code. All I was able to get was the return value from this. So, I tried returning the component's code as a string and it ended up like this. Could you please help me figure out where I'm going wrong? There might be some issue with my approach to solve this. This is actually a great project and I would really love to take this task up once I have clarity of what I had to do. I would also love to have a gmeet or a call to discuss on this. Let's get on a conclusion and discuss further. My email: [email protected] |
@DeadmanAbir Hey there, as you asked me to provide approach architecture that I will follow to fix the concerned issue. So I will try to specify you the details in structured manner: At the very beginning I shall Clone the repository and understand the current structure and dependencies. Identify Components: Create Registry Folder: I Shall Move Components: Most Importantly After Every Major Changes I Shall Test the Application: I Will Commit and Push Changes: I Shall Create Pull Request: Detailed Steps:- I Will Clone the Repository: Identify All Components: Then I Shall Create Registry Folder: Move Components: Test the Application: Commit and Push Changes: Create Pull Request: Example Of Changes To Be Made:- Before Migration: After Migration: Testing and Validation Now please verify my approach towards the issue and please assign it to me as I am very eagerly waiting to contribute into this particular project. |
|
hi @dev628140 actually not we dont want ui components to be moved in different folder that fine . What we are trying to acheive is something like this - #26 (comment) |
hi @J-B-Mugundh if go through magic ui's github you will see they have suppose |
Description:
Currently, the component codes in AgentGenesis are hardcoded in MDX files. To improve the maintainability and organization of the codebase, we propose migrating the component code to a dedicated
registry
folder. This approach will allow us to fetch the component code from theregistry
folder when it is needed in MDX files. The structure and implementation can be inspired by theregistry
folder setup in the shadcn-ui repo.Objective:
Requirements:
Refactor Component Code:
registry
folder.Update MDX Files:
registry
folder.registry
.Documentation:
Reference:
registry
folder structure and implementation can be inspired by the shadcn-ui repo.Impact:
Approval:
Additional Notes:
By migrating the component code to a dedicated
registry
folder, we aim to streamline the development process and enhance the overall quality of the AgentGenesis.The text was updated successfully, but these errors were encountered: