Making peace and breaking alliances does not clear settings

[phkb]

The functions to make peace (DayDiplomacy_040_WarEngine._makePeace) and break an alliance (DayDiplomacy_040_WarEngine._breakAlliance) do not work in their current form. This is because they are missing the second component of the lookup when checking for a "1" or a "-1".
So, lines 151-152 read

    a[aSystemId] && a[aSystemId] === 1 && (delete a[aSystemId][anotherSystemId]); // Breaking alliance
    a[anotherSystemId] && a[anotherSystemId] === 1 && (delete a[anotherSystemId][aSystemId]); // Breaking alliance

and lines 185-186 read

    a[aSystemId] && a[aSystemId] === -1 && (delete a[aSystemId][anotherSystemId]); // Making peace
    a[anotherSystemId] && a[anotherSystemId] === -1 && (delete a[anotherSystemId][aSystemId]); // Making peace

The second statement in all those lines needs an addition component, because the 1 and -1 are set against the opposing system. So, instead, they should look like this:

    a[aSystemId] && a[aSystemId][anotherSystemId] === 1 && (delete a[aSystemId][anotherSystemId]); // Breaking alliance
    a[anotherSystemId] && a[anotherSystemId][aSystemId] === 1 && (delete a[anotherSystemId][aSystemId]); // Breaking alliance

    a[aSystemId] && a[aSystemId][anotherSystemId] === -1 && (delete a[aSystemId][anotherSystemId]); // Making peace
    a[anotherSystemId] && a[anotherSystemId][aSystemId] === -1 && (delete a[anotherSystemId][aSystemId]); // Making peace

[DaymareOn]

After reviewing, you're right.
Did you test on your system?

[phkb]

I did - it stopped a constant cycle of war declarations. If only world peace was as easy to achieve!