-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HEADS UP! #692
Comments
4.0, 6.0, 7.0, 8.0, 9.0, 10.0, 11.0 OMG! 😱Version 16.0 🚀Breaking changes
Version 15.0 🚀Breaking changes
Version 14.0 🚀This version should not contain breaking changes.Add support to Version 13.0 🚀Potential Breaking changes
Version 12.0 🚀Potential Breaking changes
Version 11.0 🚀Potential Breaking changes
In Rails 5, whenever we define a This change allows ClientSideValidation to inherit validations from Version 10.0 🚀Potential Breaking changes
Client side numericality validator now mimics the behavior of server-side one. In other words, it will not accept anymore the thousand separator. Ref: #717 Version 9.0 🚀Breaking changes
This is a feature that I desired for a long time. I thought it was almost impossible to implement without a full rewrite but I was wrong and I was able to manage it in just a couple of days (after feeling reluctant for a couple of years 🤦♂️). CSV now uses a data attribute with some configuration instead of a script tag. In this way, you can block inline javascript with CSP and this will help security and cacheability In this version, I've completely dropped references to the remote validators, but you should still be able to implement one. Feel free to start a wiki or to open issues if you need extra configuration to do that. Is this the best available solution? No, of course it isn't. Is it better than before? I think so. Version 8.0 🚀This version should not contain breaking changes.🤷♂️ I've preferred to bump up the major because of potential breaking changes if you monkey patched the gem. If you didn't touch CSV internals, you should be able to use CSV >= 8.0 Version 7.0 🚀Version 7.0 drops the active record middleware. You should be able to update to this version if you didn't use remote validators before (uniqueness or custom remote validators). You should consider to setup your own implementation of remote validators and get rid of the CSV middleware because it is not secure (potential data disclosure) and it is not protected from brute force attacks Breaking changes
Version 6.0 🚀I've intentionally skipped 5.0 because I didn't want a version number which could recall Rails 5.0. As I said before, CSV will follow its own versioning system. Version 6.0 is basically the "old" 4.2 CSV updated to Rails 5. Breaking changes
New features
|
Working on setting up an Vanilla JavaScript version https://github.com/fleck/client_side_validations/tree/ES. I'm using rollup, I see you had mentioned using webpack, but for a library rollup is better suited. JS tests are passing and there's a lot of refactoring that could still be done. There are a couple of failing tests relating to copying assets. I can commit more time to this, but wanted to get some feedback before spending more time. |
@fleck thanks for your work, it looks good! Please submit a PR, I will start a review there. PS: at the moment I'm without my development machine, so please be patient |
Todo list (in priority order)
uniquenessmiddleware (Middleware should use CSRF token #512) (How to override default_scope in mutli-tenant app (with Devise) #597) (Simple suggestion how to break brute attack on uniqueness filter #612) (is_unique? check fails on MySQL and probably other storage engines #636) (Uniqueness case sensitive validation not working with mysql2 #659) (client_side_validations uses synchronous ajax #226) [7.0] 🚢What's new?
Proper SemVer
A proper SemVer allows us to break things very badly. The first feature which will be removed from CSV will be the middleware.
The Middleware
If you want need the middleware, stay on 6.0 but please note that it will not be supported and bugfixes/new features will not be backported by me.
If there is someone who wants to maintain the middleware as a separate gem, you are the welcome!
Please note that you may also need to import the middleware from the mongoid plugin
The text was updated successfully, but these errors were encountered: