Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#file becomes #filePath in Swift 5.3, #file will now just be the fileName #307

Open
clausjoergensen opened this issue Sep 2, 2020 · 3 comments

Comments

@clausjoergensen
Copy link

clausjoergensen commented Sep 2, 2020

The following code in the BaseDestination becomes obsolete due to SE-0274 as #file will now just be the fileName, whereas #filePath will be the full path.

if showFileName {
    extendedDetails += "[\((logDetails.fileName as NSString).lastPathComponent)\((showLineNumber ? ":" + String(logDetails.lineNumber) : ""))] "
}

The code can then be changed to

if showFileName {
    extendedDetails += "[\(logDetails.fileName)\((showLineNumber ? ":" + String(logDetails.lineNumber) : ""))] "
}

Swift 5.3 is currently available in the Xcode 12 beta.

@yourshinsuke
Copy link

Module compiled with Swift 5.2.2 cannot be imported by the Swift 5.3 compiler:

@yourshinsuke
Copy link

@DaveWoodCom

No more update?

@yourshinsuke
Copy link

@clausjoergensen Did you resolve?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants