Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for hostPath volume in indexer #164

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

vchendrix
Copy link
Contributor

@vchendrix vchendrix commented Feb 13, 2025

This pull request introduces a new hostPath configuration in the values.yaml file to allow the use of a hostPath volume for the index worker. If hostPath is specified, the deployment.yaml is updated to conditionally use hostPath; otherwise, it will fallback to using PersistentVolumeClaim.

Changes:

  • values.yaml: Added hostPath configuration.
  • deployment.yaml: Updated to conditionally use hostPath if specified, otherwise fallback to PersistentVolumeClaim.

Context:
Closes #162

Copy link
Collaborator

@artntek artntek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again! Left one minor suggestion

helm/templates/deployment.yaml Outdated Show resolved Hide resolved
- Adds `hostPath` configuration in `values.yaml` to allow
  using a hostPath volume for the index worker.
- Updates `deployment.yaml` to conditionally use `hostPath` if specified,
  otherwise fallback to `PersistentVolumeClaim`.

Closes DataONEorg#164
@vchendrix vchendrix force-pushed the issue-164-support-host-path branch from 0a5edb6 to ad96abf Compare February 18, 2025 19:11
@vchendrix vchendrix requested a review from artntek February 18, 2025 19:11
@vchendrix
Copy link
Contributor Author

thanks again! Left one minor suggestion

@artntek Done!

Copy link
Collaborator

@artntek artntek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome- thanks!

@artntek artntek merged commit 7ff5fab into DataONEorg:main Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable indexer-metacat-pv to Mount a Host Path
2 participants