[datadog_api_key] Fix bug introduced in 3.55.0 for organisation that doesn't have Remove config enabled #2857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…doesn't have Remove config enabled
Supam
previously approved these changes
Feb 21, 2025
tyjet
previously approved these changes
Feb 21, 2025
aliciascott
requested changes
Feb 21, 2025
There was a problem hiding this comment.
Hi @ecdatadog looks good just a small suggestion, let me know when this is ready for re-review thanks!
docs/resources/api_key.md
Outdated
| @@ -28,7 +28,7 @@ resource "datadog_api_key" "foo" { | |||
|
|
|||
| ### Optional | |||
|
|
|||
| - `remote_config_read_enabled` (Boolean) Whether the API key is used for remote config. Warning : default value is true for backwards compatibility Defaults to `true`. | |||
| - `remote_config_read_enabled` (Boolean) Whether the API key is used for remote config. Should be put to true only if remote config is enabled in /organization-settings/remote-config | |||
There was a problem hiding this comment.
Suggested change
| - `remote_config_read_enabled` (Boolean) Whether the API key is used for remote config. Should be put to true only if remote config is enabled in /organization-settings/remote-config | |
| - `remote_config_read_enabled` (Boolean) Whether the API key is used for remote config. Set to true if remote config is enabled in `/organization-settings/remote-config`. |
There was a problem hiding this comment.
Took in account but add only : Set to true only if
hestonhoffman
requested review from
hestonhoffman
and removed request for
hestonhoffman
Supam
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2847
Remove config is configured globally at org level (see /organization-settings/remote-config).
remote_config_read_enabledargument of api_key is always set tofalseremote_config_read_enabledargument is set by default totruebut can be set explicitly tofalseProposed fix :
remote_config_read_enabled, it will be the default value (true if RC is enabled, false if not) . Similar behavior as in <3.55.0remote_config_read_enabledtofalse, it will always worksremote_config_read_enabledtotrue,You will get this error if you set the argument while RC is not enabled at org level :