-
Notifications
You must be signed in to change notification settings - Fork 1
/
Copy pathchroot.go
475 lines (392 loc) · 15 KB
/
chroot.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
// SPDX-FileCopyrightText: 2024-Present Datadog, Inc
// SPDX-License-Identifier: Apache-2.0
package vfs
import (
"fmt"
"io/fs"
"path/filepath"
"strings"
"time"
)
// Chroot returns a chrooted filesystem assuming an OS base filesystem as root
// filesystem.
func Chroot(root string) (FileSystem, error) {
return ChrootFS(OS(), root)
}
// -----------------------------------------------------------------------------
type chrootFS struct {
root ConfirmedDir
unsafeFS FileSystem
}
// ConstraintError records an error and the operation and file that
// violated it.
type ConstraintError struct {
Op string
Path string
Err error
}
// Error returns the formatted error string for the ConstraintError.
func (e *ConstraintError) Error() string {
return "fs-security-constraint " + e.Op + " " + e.Path + ": " + e.Err.Error()
}
// Unwrap implements error unwrapping.
func (e *ConstraintError) Unwrap() error { return e.Err }
// Create delegates to the embedded unsafe FS after having confirmed the path
// to be inside root. If the provided path violates this constraint, an error
// of type ConstraintError is returned.
//
//nolint:wrapcheck // No need to wrap error
func (vfs chrootFS) Create(path string) (File, error) {
// Apply root prefix
path = vfs.root.Join(path)
if err := isSecurePath(vfs.unsafeFS, vfs.root, path); err != nil {
return nil, &ConstraintError{Op: "create", Path: path, Err: err}
}
return vfs.unsafeFS.Create(path)
}
// Mkdir delegates to the embedded unsafe FS after having confirmed the path
// to be inside root. If the provided path violates this constraint, an error
// of type ConstraintError is returned.
//
//nolint:wrapcheck // No need to wrap error
func (vfs chrootFS) Mkdir(path string, perm fs.FileMode) error {
// Apply root prefix
path = vfs.root.Join(path)
if err := isSecurePath(vfs.unsafeFS, vfs.root, path); err != nil {
return &ConstraintError{Op: "mkdir", Path: path, Err: err}
}
return vfs.unsafeFS.Mkdir(path, perm)
}
// MkdirAll delegates to the embedded unsafe FS after having confirmed the path
// to be inside root. If the provided path violates this constraint, an error
// type ConstraintError is returned.
//
//nolint:wrapcheck // No need to wrap error
func (vfs chrootFS) MkdirAll(path string, perm fs.FileMode) error {
// Apply root prefix
path = vfs.root.Join(path)
if err := isSecurePath(vfs.unsafeFS, vfs.root, path); err != nil {
return &ConstraintError{Op: "mkdir", Path: path, Err: err}
}
return vfs.unsafeFS.MkdirAll(path, perm)
}
// Remove delegates to the embedded unsafe FS after having confirmed the
// path to be inside root. If the provided path violates this constraint, an
// error of type ConstraintError is returned.
//
//nolint:wrapcheck // No need to wrap error
func (vfs chrootFS) Remove(path string) error {
// Apply root prefix
path = vfs.root.Join(path)
if err := isSecurePath(vfs.unsafeFS, vfs.root, path); err != nil {
return &ConstraintError{Op: "remove", Path: path, Err: err}
}
return vfs.unsafeFS.Remove(path)
}
// RemoveAll delegates to the embedded unsafe FS after having confirmed the
// path to be inside root. If the provided path violates this constraint, an
// error of type ConstraintError is returned.
//
//nolint:wrapcheck // No need to wrap error
func (vfs chrootFS) RemoveAll(path string) error {
// Apply root prefix
path = vfs.root.Join(path)
if err := isSecurePath(vfs.unsafeFS, vfs.root, path); err != nil {
return &ConstraintError{Op: "removeAll", Path: path, Err: err}
}
return vfs.unsafeFS.RemoveAll(path)
}
// Open delegates to the embedded unsafe FS after having confirmed the path
// to be inside root. If the provided path violates this constraint, an error
// of type ConstraintError is returned.
//
//nolint:wrapcheck // No need to wrap error
func (vfs chrootFS) Open(path string) (fs.File, error) {
// Apply root prefix
path = vfs.root.Join(path)
if err := isSecurePath(vfs.unsafeFS, vfs.root, path); err != nil {
return nil, &ConstraintError{Op: "open", Path: path, Err: err}
}
return vfs.unsafeFS.Open(path)
}
// Stat delegates to the embedded unsafe FS after having confirmed the path
// to be inside root. If the provided path violates this constraint, an error
// of type ConstraintError is returned.
//
//nolint:wrapcheck // No need to wrap error
func (vfs chrootFS) Stat(path string) (fs.FileInfo, error) {
// Apply root prefix
path = vfs.root.Join(path)
if err := isSecurePath(vfs.unsafeFS, vfs.root, path); err != nil {
return nil, &ConstraintError{Op: "stat", Path: path, Err: err}
}
return fs.Stat(vfs.unsafeFS, path)
}
// IsDir delegates to the embedded unsafe FS after having confirmed the path
// to be inside root. If the provided path violates this constraint, it returns
// false.
func (vfs chrootFS) IsDir(path string) bool {
// Apply root prefix
path = vfs.root.Join(path)
if err := isSecurePath(vfs.unsafeFS, vfs.root, path); err != nil {
return false
}
return vfs.unsafeFS.IsDir(path)
}
// ReadDir delegates to the embedded unsafe FS after having confirmed the path
// to be inside root. If the provided path violates this constraint, an error
// of type ConstraintError is returned.
//
//nolint:wrapcheck // No need to wrap error
func (vfs chrootFS) ReadDir(path string) ([]fs.DirEntry, error) {
// Apply root prefix
path = vfs.root.Join(path)
if err := isSecurePath(vfs.unsafeFS, vfs.root, path); err != nil {
return nil, &ConstraintError{Op: "open", Path: path, Err: err}
}
return fs.ReadDir(vfs.unsafeFS, path)
}
// Resolve delegates to the embedded unsafe FS, but confirms the returned
// result to be within root. If the results violates this constraint, an error
// of type ConstraintError is returned.
//
//nolint:wrapcheck // No need to wrap error
func (vfs chrootFS) Resolve(path string) (ConfirmedDir, string, error) {
// Apply root prefix
path = vfs.root.Join(path)
d, f, err := vfs.unsafeFS.Resolve(path)
if err != nil {
return d, f, err
}
if !d.HasPrefix(vfs.root) {
return "", "", &ConstraintError{Op: "abs", Path: path, Err: rootConstraintErr(path, vfs.root.String())}
}
// Resolve should return an absolute path
newPath := filepath.Clean(strings.TrimPrefix(d.String(), vfs.root.String()))
if newPath == SelfDir {
return ConfirmedDir(FakeRoot), f, err
}
return ConfirmedDir(filepath.ToSlash(newPath)), f, err
}
// Exists delegates to the embedded unsafe FS after having confirmed the path
// to be inside root. If the provided path violates this constraint, it returns
// false.
func (vfs chrootFS) Exists(path string) bool {
// Apply root prefix
path = vfs.root.Join(path)
if err := isSecurePath(vfs.unsafeFS, vfs.root, path); err != nil {
return false
}
return vfs.unsafeFS.Exists(path)
}
// Glob delegates to the embedded unsafe FS, but filters the returned paths to
// only include items inside root.
//
//nolint:wrapcheck // No need to wrap error
func (vfs chrootFS) Glob(pattern string) ([]string, error) {
paths, err := fs.Glob(vfs.unsafeFS, vfs.root.Join(pattern))
if err != nil {
return nil, err
}
var securePaths []string
for _, p := range paths {
if err := isSecurePath(vfs.unsafeFS, vfs.root, p); err == nil {
securePaths = append(securePaths, p)
}
}
return securePaths, err
}
// ReadFile delegates to the embedded unsafe FS after having confirmed the path
// to be inside root. If the provided path violates this constraint, an error
// of type ConstraintError is returned.
//
//nolint:wrapcheck // No need to wrap error
func (vfs chrootFS) ReadFile(path string) ([]byte, error) {
// Apply root prefix
path = vfs.root.Join(path)
if err := isSecurePath(vfs.unsafeFS, vfs.root, path); err != nil {
return nil, &ConstraintError{Op: "read", Path: path, Err: err}
}
return fs.ReadFile(vfs.unsafeFS, path)
}
// WriteFile delegates to the embedded unsafe FS after having confirmed the
// path to be inside root. If the provided path violates this constraint, an
// error of type ConstraintError is returned.
//
//nolint:wrapcheck // No need to wrap error
func (vfs chrootFS) WriteFile(path string, data []byte, perm fs.FileMode) error {
// Apply root prefix
path = vfs.root.Join(path)
if err := isSecurePath(vfs.unsafeFS, vfs.root, path); err != nil {
return &ConstraintError{Op: "writeFile", Path: path, Err: err}
}
return vfs.unsafeFS.WriteFile(path, data, perm)
}
// WalkDir delegates to the embedded unsafe FS, wrapping walkFn in a callback which
// confirms the path to be inside root. If the path violates this constraint,
// an error of type ConstraintError is returned and walkFn is not called.
//
//nolint:wrapcheck // No need to wrap error
func (vfs chrootFS) WalkDir(path string, walkFn fs.WalkDirFunc) error {
// Apply root prefix
path = vfs.root.Join(path)
wrapWalkFn := func(path string, info fs.DirEntry, err error) error {
if err := isSecurePath(vfs.unsafeFS, vfs.root, path); err != nil {
return &ConstraintError{Op: "walk", Path: path, Err: err}
}
return walkFn(path, info, err)
}
return fs.WalkDir(vfs.unsafeFS, path, wrapWalkFn)
}
// Chmod delegates to the embedded unsafe FS after having confirmed the path
// to be inside root. If the provided path violates this constraint, an error
// of type ConstraintError is returned.
//
//nolint:wrapcheck // No need to wrap error
func (vfs chrootFS) Chmod(path string, mode fs.FileMode) error {
// Apply root prefix
path = vfs.root.Join(path)
if err := isSecurePath(vfs.unsafeFS, vfs.root, path); err != nil {
return &ConstraintError{Op: "chmod", Path: path, Err: err}
}
return vfs.unsafeFS.Chmod(path, mode)
}
// Chown delegates to the embedded unsafe FS after having confirmed the path
// to be inside root. If the provided path violates this constraint, an error
// of type ConstraintError is returned.
//
//nolint:wrapcheck // No need to wrap error
func (vfs chrootFS) Chown(path string, uid, gid int) error {
// Apply root prefix
path = vfs.root.Join(path)
if err := isSecurePath(vfs.unsafeFS, vfs.root, path); err != nil {
return &ConstraintError{Op: "chown", Path: path, Err: err}
}
return vfs.unsafeFS.Chown(path, uid, gid)
}
// Chtimes delegates to the embedded unsafe FS after having confirmed the path
// to be inside root. If the provided path violates this constraint, an error
// of type ConstraintError is returned.
//
//nolint:wrapcheck // No need to wrap error
func (vfs chrootFS) Chtimes(path string, atime, mtime time.Time) error {
// Apply root prefix
path = vfs.root.Join(path)
if err := isSecurePath(vfs.unsafeFS, vfs.root, path); err != nil {
return &ConstraintError{Op: "chtimes", Path: path, Err: err}
}
return vfs.unsafeFS.Chtimes(path, atime, mtime)
}
// Symlink delegates to the embedded unsafe FS after having confirmed the path
// to be inside root. If the provided path violates this constraint, an error
// of type ConstraintError is returned.
//
//nolint:wrapcheck // No need to wrap error
func (vfs chrootFS) Symlink(sourcePath, targetName string) error {
// Apply root prefix
sourcePath = vfs.root.Join(sourcePath)
targetName = vfs.root.Join(targetName)
// Symlink should be relative to the new path when used in the chroot
rel, err := filepath.Rel(filepath.Dir(targetName), sourcePath)
if err != nil {
return fmt.Errorf("symlink path %q is not relative to %q: %w", sourcePath, targetName, err)
}
symlinkPath := filepath.Join(filepath.Dir(targetName), rel)
// Ensure the symlink is secure
if err := isSecurePath(vfs.unsafeFS, vfs.root, sourcePath); err != nil {
return &ConstraintError{Op: "symlink", Path: sourcePath, Err: err}
}
if err := isSecurePath(vfs.unsafeFS, vfs.root, targetName); err != nil {
return &ConstraintError{Op: "symlink", Path: targetName, Err: err}
}
if err := isSecurePath(vfs.unsafeFS, vfs.root, symlinkPath); err != nil {
return &ConstraintError{Op: "symlink", Path: symlinkPath, Err: err}
}
return vfs.unsafeFS.Symlink(rel, targetName)
}
// Link delegates to the embedded unsafe FS after having confirmed the path
// to be inside root. If the provided path violates this constraint, an error
// of type ConstraintError is returned.
//
//nolint:wrapcheck // No need to wrap error
func (vfs chrootFS) Link(sourcePath, targetName string) error {
// Apply root prefix
sourcePath = vfs.root.Join(sourcePath)
targetName = vfs.root.Join(targetName)
if err := isSecurePath(vfs.unsafeFS, vfs.root, sourcePath); err != nil {
return &ConstraintError{Op: "link", Path: sourcePath, Err: err}
}
if err := isSecurePath(vfs.unsafeFS, vfs.root, targetName); err != nil {
return &ConstraintError{Op: "link", Path: targetName, Err: err}
}
return vfs.unsafeFS.Link(sourcePath, targetName)
}
// Lstat delegates to the embedded unsafe FS after having confirmed the path
// to be inside root. If the provided path violates this constraint, an error
// of type ConstraintError is returned.
//
//nolint:wrapcheck // No need to wrap error
func (vfs chrootFS) Lstat(path string) (fs.FileInfo, error) {
// Apply root prefix
path = vfs.root.Join(path)
if err := isSecurePath(vfs.unsafeFS, vfs.root, path); err != nil {
return nil, &ConstraintError{Op: "lstat", Path: path, Err: err}
}
return vfs.unsafeFS.Lstat(path)
}
// ReadLink delegates to the embedded unsafe FS after having confirmed the path
// to be inside root. If the provided path violates this constraint, an error
// of type ConstraintError is returned.
//
//nolint:wrapcheck // No need to wrap error
func (vfs chrootFS) ReadLink(path string) (string, error) {
// Apply root prefix
path = vfs.root.Join(path)
if err := isSecurePath(vfs.unsafeFS, vfs.root, path); err != nil {
return "", &ConstraintError{Op: "readlink", Path: path, Err: err}
}
return vfs.unsafeFS.ReadLink(path)
}
// Truncate delegates to the embedded unsafe FS after having confirmed the path
// to be inside root. If the provided path violates this constraint, an error
// of type ConstraintError is returned.
//
//nolint:wrapcheck // No need to wrap error
func (vfs chrootFS) Truncate(name string, size int64) error {
// Apply root prefix
name = vfs.root.Join(name)
if err := isSecurePath(vfs.unsafeFS, vfs.root, name); err != nil {
return &ConstraintError{Op: "truncate", Path: name, Err: err}
}
return vfs.unsafeFS.Truncate(name, size)
}
// -----------------------------------------------------------------------------
// isSecurePath confirms the given path is inside root using the provided file
// system. At present, it assumes the file system implementation to be on disk
// and makes use of filepath.EvalSymlinks.
func isSecurePath(vfs FileSystem, root ConfirmedDir, path string) error {
// Ensure absolute path
absRoot, err := filepath.Abs(filepath.FromSlash(path))
if err != nil {
return fmt.Errorf("abs path error on '%s': %v", path, err)
}
d := ConfirmedDir(absRoot)
if vfs.Exists(absRoot) {
evaluated, err := filepath.EvalSymlinks(absRoot)
if err != nil {
return fmt.Errorf("evalsymlink failure on '%s': %w", path, err)
}
evaluatedDir := evaluated
if !vfs.IsDir(evaluatedDir) {
evaluatedDir = filepath.Dir(evaluatedDir)
}
d = ConfirmedDir(evaluatedDir)
}
if !d.HasPrefix(root) {
return rootConstraintErr(path, root.String())
}
return nil
}
func rootConstraintErr(path, root string) error {
return fmt.Errorf("path %q is not in or below %q", path, root)
}