From 4a6c08e83824d2f95b9c056d925dfcfe00315a86 Mon Sep 17 00:00:00 2001 From: Alexey Kuznetsov Date: Fri, 5 Dec 2025 13:49:56 -0500 Subject: [PATCH 1/2] Enable `Spotbugs` and `Spotless` for modules that require JDK21+. --- dd-smoke-tests/concurrent/java-21/build.gradle | 4 ---- dd-smoke-tests/concurrent/java-25/build.gradle | 4 ---- .../main/java/datadog/smoketest/concurrent/NestedTasks.java | 1 + 3 files changed, 1 insertion(+), 8 deletions(-) diff --git a/dd-smoke-tests/concurrent/java-21/build.gradle b/dd-smoke-tests/concurrent/java-21/build.gradle index 35fadfa2a29..e71a8eccb88 100644 --- a/dd-smoke-tests/concurrent/java-21/build.gradle +++ b/dd-smoke-tests/concurrent/java-21/build.gradle @@ -32,10 +32,6 @@ tasks.named("forbiddenApisMain") { failOnMissingClasses = false } -['spotlessApply', 'spotlessCheck', 'spotlessJava', 'spotbugsMain'].each { - tasks.named(it) { enabled = false } -} - application { mainClass = 'datadog.smoketest.concurrent.ConcurrentApp' } diff --git a/dd-smoke-tests/concurrent/java-25/build.gradle b/dd-smoke-tests/concurrent/java-25/build.gradle index c77993038a5..fa997d27122 100644 --- a/dd-smoke-tests/concurrent/java-25/build.gradle +++ b/dd-smoke-tests/concurrent/java-25/build.gradle @@ -45,10 +45,6 @@ tasks.named("forbiddenApisMain") { failOnMissingClasses = false } -['spotlessApply', 'spotlessCheck', 'spotlessJava', 'spotbugsMain'].each { - tasks.named(it) { enabled = false } -} - application { mainClass = 'datadog.smoketest.concurrent.ConcurrentApp' } diff --git a/dd-smoke-tests/concurrent/java-25/src/main/java/datadog/smoketest/concurrent/NestedTasks.java b/dd-smoke-tests/concurrent/java-25/src/main/java/datadog/smoketest/concurrent/NestedTasks.java index 52e60502465..f3b15067e8f 100644 --- a/dd-smoke-tests/concurrent/java-25/src/main/java/datadog/smoketest/concurrent/NestedTasks.java +++ b/dd-smoke-tests/concurrent/java-25/src/main/java/datadog/smoketest/concurrent/NestedTasks.java @@ -33,6 +33,7 @@ void task2() { void subTask1() { // Some basic computations here } + @WithSpan("great-child1-2") void subTask2() { // Some basic computations here From 5b6c848d1de67f0484499944fe9374a1ccd0d96c Mon Sep 17 00:00:00 2001 From: Alexey Kuznetsov Date: Wed, 10 Dec 2025 17:41:48 -0500 Subject: [PATCH 2/2] Spotless --- .../smoketest/concurrent/VirtualThreadStartCalculator.java | 1 + 1 file changed, 1 insertion(+) diff --git a/dd-smoke-tests/concurrent/java-21/src/main/java/datadog/smoketest/concurrent/VirtualThreadStartCalculator.java b/dd-smoke-tests/concurrent/java-21/src/main/java/datadog/smoketest/concurrent/VirtualThreadStartCalculator.java index a58a14022eb..c47aacba2dc 100644 --- a/dd-smoke-tests/concurrent/java-21/src/main/java/datadog/smoketest/concurrent/VirtualThreadStartCalculator.java +++ b/dd-smoke-tests/concurrent/java-21/src/main/java/datadog/smoketest/concurrent/VirtualThreadStartCalculator.java @@ -14,6 +14,7 @@ public long computeFibonacci(int n) throws ExecutionException, InterruptedExcept @Override public void close() { + // No-op. } public static class FibonacciExecuteTask implements Runnable {