-
Notifications
You must be signed in to change notification settings - Fork 319
Add Gradle Task to Parse V2 supported-configurations.json Format
#10060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~9848897005, baseline=1.57.0-SNAPSHOT~5c5592a6f6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1085513
Total [baseline] (8.779 s) : 0, 8778566
Agent [candidate] (1.079 s) : 0, 1078821
Total [candidate] (8.716 s) : 0, 8716035
section iast
Agent [baseline] (1.221 s) : 0, 1220766
Total [baseline] (9.482 s) : 0, 9482018
Agent [candidate] (1.224 s) : 0, 1223651
Total [candidate] (9.479 s) : 0, 9479165
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~9848897005, baseline=1.57.0-SNAPSHOT~5c5592a6f6
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (651.15 ms) : 0, 651150
BytebuddyAgent [candidate] (648.055 ms) : 0, 648055
GlobalTracer [baseline] (284.303 ms) : 0, 284303
GlobalTracer [candidate] (281.614 ms) : 0, 281614
AppSec [baseline] (32.483 ms) : 0, 32483
AppSec [candidate] (32.099 ms) : 0, 32099
Debugger [baseline] (67.338 ms) : 0, 67338
Debugger [candidate] (66.947 ms) : 0, 66947
Remote Config [baseline] (654.627 µs) : 0, 655
Remote Config [candidate] (659.946 µs) : 0, 660
Telemetry [baseline] (8.965 ms) : 0, 8965
Telemetry [candidate] (9.011 ms) : 0, 9011
Flare Poller [baseline] (3.808 ms) : 0, 3808
Flare Poller [candidate] (3.793 ms) : 0, 3793
section iast
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (789.512 ms) : 0, 789512
BytebuddyAgent [candidate] (791.932 ms) : 0, 791932
GlobalTracer [baseline] (255.265 ms) : 0, 255265
GlobalTracer [candidate] (255.431 ms) : 0, 255431
IAST [baseline] (26.981 ms) : 0, 26981
IAST [candidate] (26.977 ms) : 0, 26977
AppSec [baseline] (35.358 ms) : 0, 35358
AppSec [candidate] (34.836 ms) : 0, 34836
Debugger [baseline] (64.637 ms) : 0, 64637
Debugger [candidate] (65.512 ms) : 0, 65512
Remote Config [baseline] (585.562 µs) : 0, 586
Remote Config [candidate] (585.024 µs) : 0, 585
Telemetry [baseline] (8.449 ms) : 0, 8449
Telemetry [candidate] (8.394 ms) : 0, 8394
Flare Poller [baseline] (3.471 ms) : 0, 3471
Flare Poller [candidate] (3.435 ms) : 0, 3435
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~9848897005, baseline=1.57.0-SNAPSHOT~5c5592a6f6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1084036
Total [baseline] (10.912 s) : 0, 10911796
Agent [candidate] (1.08 s) : 0, 1079753
Total [candidate] (10.902 s) : 0, 10901612
section appsec
Agent [baseline] (1.27 s) : 0, 1269870
Total [baseline] (11.06 s) : 0, 11060091
Agent [candidate] (1.261 s) : 0, 1260623
Total [candidate] (11.105 s) : 0, 11104706
section iast
Agent [baseline] (1.224 s) : 0, 1223832
Total [baseline] (11.206 s) : 0, 11206039
Agent [candidate] (1.232 s) : 0, 1231997
Total [candidate] (11.168 s) : 0, 11167760
section profiling
Agent [baseline] (1.202 s) : 0, 1201634
Total [baseline] (11.01 s) : 0, 11009609
Agent [candidate] (1.202 s) : 0, 1202298
Total [candidate] (10.964 s) : 0, 10963874
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~9848897005, baseline=1.57.0-SNAPSHOT~5c5592a6f6
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.205 ms) : 0, 1205
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (648.902 ms) : 0, 648902
BytebuddyAgent [candidate] (647.989 ms) : 0, 647989
GlobalTracer [baseline] (283.576 ms) : 0, 283576
GlobalTracer [candidate] (281.284 ms) : 0, 281284
AppSec [baseline] (32.727 ms) : 0, 32727
AppSec [candidate] (32.251 ms) : 0, 32251
Debugger [baseline] (68.534 ms) : 0, 68534
Debugger [candidate] (68.029 ms) : 0, 68029
Remote Config [baseline] (627.038 µs) : 0, 627
Remote Config [candidate] (657.272 µs) : 0, 657
Telemetry [baseline] (9.073 ms) : 0, 9073
Telemetry [candidate] (9.112 ms) : 0, 9112
Flare Poller [baseline] (3.846 ms) : 0, 3846
Flare Poller [candidate] (3.824 ms) : 0, 3824
section appsec
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (692.637 ms) : 0, 692637
BytebuddyAgent [candidate] (687.386 ms) : 0, 687386
GlobalTracer [baseline] (260.503 ms) : 0, 260503
GlobalTracer [candidate] (258.905 ms) : 0, 258905
IAST [baseline] (24.582 ms) : 0, 24582
IAST [candidate] (24.449 ms) : 0, 24449
AppSec [baseline] (175.086 ms) : 0, 175086
AppSec [candidate] (173.955 ms) : 0, 173955
Debugger [baseline] (66.687 ms) : 0, 66687
Debugger [candidate] (65.777 ms) : 0, 65777
Remote Config [baseline] (718.874 µs) : 0, 719
Remote Config [candidate] (737.025 µs) : 0, 737
Telemetry [baseline] (9.122 ms) : 0, 9122
Telemetry [candidate] (8.899 ms) : 0, 8899
Flare Poller [baseline] (3.952 ms) : 0, 3952
Flare Poller [candidate] (3.827 ms) : 0, 3827
section iast
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.203 ms) : 0, 1203
BytebuddyAgent [baseline] (791.635 ms) : 0, 791635
BytebuddyAgent [candidate] (797.421 ms) : 0, 797421
GlobalTracer [baseline] (255.322 ms) : 0, 255322
GlobalTracer [candidate] (256.456 ms) : 0, 256456
IAST [baseline] (26.896 ms) : 0, 26896
IAST [candidate] (27.193 ms) : 0, 27193
AppSec [baseline] (35.216 ms) : 0, 35216
AppSec [candidate] (34.54 ms) : 0, 34540
Debugger [baseline] (65.826 ms) : 0, 65826
Debugger [candidate] (67.337 ms) : 0, 67337
Remote Config [baseline] (575.454 µs) : 0, 575
Remote Config [candidate] (572.437 µs) : 0, 572
Telemetry [baseline] (8.422 ms) : 0, 8422
Telemetry [candidate] (8.369 ms) : 0, 8369
Flare Poller [baseline] (3.447 ms) : 0, 3447
Flare Poller [candidate] (3.454 ms) : 0, 3454
section profiling
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (699.914 ms) : 0, 699914
BytebuddyAgent [candidate] (701.25 ms) : 0, 701250
GlobalTracer [baseline] (220.172 ms) : 0, 220172
GlobalTracer [candidate] (220.516 ms) : 0, 220516
AppSec [baseline] (32.126 ms) : 0, 32126
AppSec [candidate] (32.049 ms) : 0, 32049
Debugger [baseline] (68.439 ms) : 0, 68439
Debugger [candidate] (67.923 ms) : 0, 67923
Remote Config [baseline] (626.319 µs) : 0, 626
Remote Config [candidate] (618.087 µs) : 0, 618
Telemetry [baseline] (8.932 ms) : 0, 8932
Telemetry [candidate] (8.885 ms) : 0, 8885
Flare Poller [baseline] (3.769 ms) : 0, 3769
Flare Poller [candidate] (3.777 ms) : 0, 3777
ProfilingAgent [baseline] (97.005 ms) : 0, 97005
ProfilingAgent [candidate] (96.764 ms) : 0, 96764
Profiling [baseline] (97.585 ms) : 0, 97585
Profiling [candidate] (97.35 ms) : 0, 97350
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 4 performance regressions! Performance is the same for 15 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~9848897005, baseline=1.57.0-SNAPSHOT~5c5592a6f6
dateFormat X
axisFormat %s
section baseline
no_agent (1.333 ms) : 1320, 1346
. : milestone, 1333,
iast (3.515 ms) : 3470, 3559
. : milestone, 3515,
iast_FULL (6.284 ms) : 6219, 6350
. : milestone, 6284,
iast_GLOBAL (3.824 ms) : 3751, 3896
. : milestone, 3824,
profiling (2.701 ms) : 2675, 2727
. : milestone, 2701,
tracing (1.928 ms) : 1912, 1944
. : milestone, 1928,
section candidate
no_agent (1.334 ms) : 1320, 1348
. : milestone, 1334,
iast (3.519 ms) : 3466, 3573
. : milestone, 3519,
iast_FULL (6.635 ms) : 6562, 6708
. : milestone, 6635,
iast_GLOBAL (3.97 ms) : 3911, 4029
. : milestone, 3970,
profiling (2.205 ms) : 2183, 2226
. : milestone, 2205,
tracing (1.959 ms) : 1943, 1976
. : milestone, 1959,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~9848897005, baseline=1.57.0-SNAPSHOT~5c5592a6f6
dateFormat X
axisFormat %s
section baseline
no_agent (18.675 ms) : 18483, 18867
. : milestone, 18675,
appsec (19.184 ms) : 18986, 19382
. : milestone, 19184,
code_origins (18.338 ms) : 18151, 18524
. : milestone, 18338,
iast (18.351 ms) : 18166, 18536
. : milestone, 18351,
profiling (20.076 ms) : 19875, 20277
. : milestone, 20076,
tracing (18.375 ms) : 18189, 18561
. : milestone, 18375,
section candidate
no_agent (19.896 ms) : 19691, 20102
. : milestone, 19896,
appsec (19.43 ms) : 19230, 19630
. : milestone, 19430,
code_origins (18.574 ms) : 18389, 18760
. : milestone, 18574,
iast (18.213 ms) : 18032, 18395
. : milestone, 18213,
profiling (20.33 ms) : 20123, 20538
. : milestone, 20330,
tracing (18.415 ms) : 18231, 18599
. : milestone, 18415,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~9848897005, baseline=1.57.0-SNAPSHOT~5c5592a6f6
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1470, 1493
. : milestone, 1481,
appsec (3.733 ms) : 3513, 3952
. : milestone, 3733,
iast (2.217 ms) : 2153, 2282
. : milestone, 2217,
iast_GLOBAL (2.259 ms) : 2194, 2324
. : milestone, 2259,
profiling (2.083 ms) : 2029, 2138
. : milestone, 2083,
tracing (2.053 ms) : 2002, 2104
. : milestone, 2053,
section candidate
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (3.706 ms) : 3488, 3924
. : milestone, 3706,
iast (2.226 ms) : 2161, 2291
. : milestone, 2226,
iast_GLOBAL (2.268 ms) : 2202, 2333
. : milestone, 2268,
profiling (2.095 ms) : 2041, 2150
. : milestone, 2095,
tracing (2.059 ms) : 2007, 2110
. : milestone, 2059,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~9848897005, baseline=1.57.0-SNAPSHOT~5c5592a6f6
dateFormat X
axisFormat %s
section baseline
no_agent (14.769 s) : 14769000, 14769000
. : milestone, 14769000,
appsec (14.674 s) : 14674000, 14674000
. : milestone, 14674000,
iast (18.125 s) : 18125000, 18125000
. : milestone, 18125000,
iast_GLOBAL (17.964 s) : 17964000, 17964000
. : milestone, 17964000,
profiling (14.439 s) : 14439000, 14439000
. : milestone, 14439000,
tracing (14.819 s) : 14819000, 14819000
. : milestone, 14819000,
section candidate
no_agent (14.794 s) : 14794000, 14794000
. : milestone, 14794000,
appsec (14.997 s) : 14997000, 14997000
. : milestone, 14997000,
iast (18.104 s) : 18104000, 18104000
. : milestone, 18104000,
iast_GLOBAL (18.03 s) : 18030000, 18030000
. : milestone, 18030000,
profiling (14.276 s) : 14276000, 14276000
. : milestone, 14276000,
tracing (14.567 s) : 14567000, 14567000
. : milestone, 14567000,
|
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
PerfectSlayer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a minor comment as part of mentoring. I will leave the full review / feedback to the reviewers :)
utils/config-utils/src/main/java/datadog/trace/config/inversion/SupportedConfiguration.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/kotlin/datadog/gradle/plugin/config/ParseV2SupportedConfigurationsTask.kt
Show resolved
Hide resolved
buildSrc/src/main/kotlin/datadog/gradle/plugin/config/ParseV2SupportedConfigurationsTask.kt
Outdated
Show resolved
Hide resolved
| if (s == null) "null" else "\"${esc(s)}\"" | ||
| } | ||
|
|
||
| data class SupportedConfiguration( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: I'd rename this one as it is confusing with the outer class with the same name.
buildSrc/src/main/kotlin/datadog/gradle/plugin/config/ParseV2SupportedConfigurationsTask.kt
Show resolved
Hide resolved
bric3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-approving.
| if (s == null) "null" else "\"${esc(s)}\"" | ||
| } | ||
|
|
||
| data class SupportedConfigurationObject( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: Maybe this one should be private. Also rather than Object suffix I propose Item, or Element as this suggest this type is part of a collection.
| data class SupportedConfigurationObject( | |
| data class SupportedConfigurationItem( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...or maybe SupportedConfigurationInternal
What Does This Do
This PR adds a new Gradle task to parse the V2 format for the local
supported-configurations.jsonfile. This task is based off of the original parsing taskParseSupportedConfigurationsTaskwhich handled the V1 format.Note that this is the first of many PRs to migrate to the V2 format. This task will be hooked into the generate task in a future PR.
Below are examples of the format of the two files:
This PR creates a new Java class
SupportedConfiguration.javainutils:config-utilsto support storing an individual Config version. The Gradle task parses the JSON and stores the data in instances of the object. Consequently, the new generated classGeneratedSupportedConfiguration.javawill now store aMap<String, List<SupportedConfiguration>>in itsSUPPORTEDfield.Additionally, the new V2 format does not have a top-level aliases field; rather aliases are tied to config versions. Until Config Registry becomes mature enough to understand what version of a config the customer is using, we will still generate a top-level aliases map that considers all aliases of a config, regardless of which version is actually being used.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]