refactor(profiling): Consolidate converter script output for clarity

Simplified the conversion script output to avoid duplicate information:

Default mode (no flags):
- Single concise line: "[SUCCESS] Converted: output.pb (45.2KB, 127ms)"
- No verbose converter output shown
- Perfect for scripting and quick conversions

Diagnostics mode (--diagnostics):
- Shows converter's detailed output (files, format, time)
- Enhanced diagnostics section with compression metrics
- Clear input→output flow visualization
- Space savings calculations

Changes:
- Removed duplicate "Converting..." and "Conversion complete" messages
- Eliminated redundant output file info in default mode
- Consolidated size/time reporting
- Renamed section to "Enhanced Diagnostics" to distinguish from converter output

Example outputs:

Default:
  [SUCCESS] Converted: output.pb (45.2KB, 127ms)

With --diagnostics:
  [DIAG] Input: recording.jfr (89.3KB)
  Converting 1 JFR file(s) to OTLP format...
    Adding: recording.jfr
  Conversion complete!
    Output: output.pb
    Format: PROTO
    Size: 45.2 KB
    Time: 127 ms

  [DIAG] === Enhanced Diagnostics ===
  [DIAG] Input → Output: 89.3KB → 45.2KB
  [DIAG] Compression: 50.6% of original
  [DIAG] Space saved: 44.1KB (49.4% reduction)

Documentation updated in CLI.md with both output examples.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: jbachorik

dd-java-agent/agent-profiling/profiling-otel/convert-jfr.sh

@@ -276,8 +276,6 @@ fi
 # Ensure fat jar is built and get its path
 FAT_JAR=$(ensure_fat_jar)
 
-log_info "Converting JFR to OTLP format..."
-
 # Run conversion using fat jar and capture output
 # Suppress SLF4J warnings (it defaults to NOP logger which is fine for CLI)
 CONVERTER_OUTPUT=$(java -jar "$FAT_JAR" "${CONVERTER_ARGS[@]}" 2>&1 | grep -vE "^SLF4J:|SLF4JServiceProvider")
@@ -287,41 +285,35 @@ if [ $CONVERTER_EXIT -eq 0 ]; then
     # Extract output file (last argument)
     OUTPUT_FILE="${CONVERTER_ARGS[-1]}"
 
-    # Print converter output
-    echo "$CONVERTER_OUTPUT"
-
-    log_success "Conversion completed successfully!"
+    if [ "$SHOW_DIAGNOSTICS" = true ]; then
+        # With diagnostics: show converter output plus enhanced metrics
+        echo "$CONVERTER_OUTPUT"
 
-    if [ -f "$OUTPUT_FILE" ]; then
         OUTPUT_SIZE=$(get_file_size_bytes "$OUTPUT_FILE")
-        SIZE=$(format_bytes $OUTPUT_SIZE)
-        log_info "Output file: $OUTPUT_FILE ($SIZE)"
 
-        if [ "$SHOW_DIAGNOSTICS" = true ]; then
-            echo ""
-            log_diagnostic "=== Conversion Diagnostics ==="
+        echo ""
+        log_diagnostic "=== Enhanced Diagnostics ==="
 
-            # Extract conversion time from converter output (looks for "Time: XXX ms")
-            CONVERSION_TIME=$(echo "$CONVERTER_OUTPUT" | grep -o 'Time: [0-9]* ms' | grep -o '[0-9]*' | head -1)
-            if [ -n "$CONVERSION_TIME" ] && [ "$CONVERSION_TIME" != "" ]; then
-                log_diagnostic "Conversion time: ${CONVERSION_TIME}ms"
-            fi
+        # Show size comparison with input
+        if [ ${#INPUT_FILES[@]} -gt 0 ]; then
+            RATIO=$(calc_compression_ratio $TOTAL_INPUT_SIZE $OUTPUT_SIZE)
+            log_diagnostic "Input → Output: $(format_bytes $TOTAL_INPUT_SIZE) → $(format_bytes $OUTPUT_SIZE)"
+            log_diagnostic "Compression: $RATIO of original"
 
-            # Show size comparison
-            if [ ${#INPUT_FILES[@]} -gt 0 ]; then
-                RATIO=$(calc_compression_ratio $TOTAL_INPUT_SIZE $OUTPUT_SIZE)
-                log_diagnostic "Output size: $(format_bytes $OUTPUT_SIZE)"
-                log_diagnostic "Size ratio: $RATIO of input"
-
-                if [ "$OUTPUT_SIZE" -lt "$TOTAL_INPUT_SIZE" ]; then
-                    SAVINGS=$((TOTAL_INPUT_SIZE - OUTPUT_SIZE))
-                    SAVINGS_PCT=$(awk "BEGIN {printf \"%.1f%%\", (1 - $OUTPUT_SIZE/$TOTAL_INPUT_SIZE) * 100}")
-                    log_diagnostic "Savings: $(format_bytes $SAVINGS) ($SAVINGS_PCT reduction)"
-                fi
+            if [ "$OUTPUT_SIZE" -lt "$TOTAL_INPUT_SIZE" ]; then
+                SAVINGS=$((TOTAL_INPUT_SIZE - OUTPUT_SIZE))
+                SAVINGS_PCT=$(awk "BEGIN {printf \"%.1f%%\", (1 - $OUTPUT_SIZE/$TOTAL_INPUT_SIZE) * 100}")
+                log_diagnostic "Space saved: $(format_bytes $SAVINGS) ($SAVINGS_PCT reduction)"
             fi
-
-            echo ""
         fi
+        echo ""
+    else
+        # Without diagnostics: concise output
+        # Extract just the key info from converter output
+        CONVERSION_TIME=$(echo "$CONVERTER_OUTPUT" | grep -o 'Time: [0-9]* ms' | grep -o '[0-9]*' | head -1)
+        OUTPUT_SIZE=$(get_file_size_bytes "$OUTPUT_FILE")
+
+        log_success "Converted: $OUTPUT_FILE ($(format_bytes $OUTPUT_SIZE), ${CONVERSION_TIME}ms)"
     fi
 else
     echo "$CONVERTER_OUTPUT"

dd-java-agent/agent-profiling/profiling-otel/doc/CLI.md

@@ -364,19 +364,27 @@ Show detailed diagnostics:
 ./convert-jfr.sh --diagnostics recording.jfr output.pb
 ```
 
-Output:
+Output with diagnostics:
 ```
-[INFO] Converting JFR to OTLP format...
 [DIAG] Input: recording.jfr (89.3KB)
 [DIAG] Total input size: 89.3KB
-[SUCCESS] Conversion completed successfully!
-[INFO] Output file: output.pb (45.2KB)
+Converting 1 JFR file(s) to OTLP format...
+  Adding: recording.jfr
+Conversion complete!
+  Output: output.pb
+  Format: PROTO
+  Size: 45.2 KB
+  Time: 127 ms
 
-[DIAG] === Conversion Diagnostics ===
-[DIAG] Wall time: 127.3ms
-[DIAG] Output size: 45.2KB
-[DIAG] Size ratio: 50.6% of input
-[DIAG] Savings: 44.1KB (49.4% reduction)
+[DIAG] === Enhanced Diagnostics ===
+[DIAG] Input → Output: 89.3KB → 45.2KB
+[DIAG] Compression: 50.6% of original
+[DIAG] Space saved: 44.1KB (49.4% reduction)
+```
+
+Without diagnostics (concise):
+```
+[SUCCESS] Converted: output.pb (45.2KB, 127ms)
 ```
 
 ### Features
@@ -391,11 +399,26 @@ Output:
 
 ### Script Output
 
+Without diagnostics (default):
+```
+[SUCCESS] Converted: output.pb (45.2KB, 127ms)
+```
+
+With --diagnostics flag:
 ```
-[INFO] Converting JFR to OTLP format...
-[INFO] Arguments: recording.jfr output.pb
-[SUCCESS] Conversion completed successfully!
-[INFO] Output file: output.pb (45K)
+[DIAG] Input: recording.jfr (89.3KB)
+Converting 1 JFR file(s) to OTLP format...
+  Adding: recording.jfr
+Conversion complete!
+  Output: output.pb
+  Format: PROTO
+  Size: 45.2 KB
+  Time: 127 ms
+
+[DIAG] === Enhanced Diagnostics ===
+[DIAG] Input → Output: 89.3KB → 45.2KB
+[DIAG] Compression: 50.6% of original
+[DIAG] Space saved: 44.1KB (49.4% reduction)
 ```
 
 ### When to Use