fix: jsp instrumentation needlessly requiring jetty http status

Author: bric3

dd-java-agent/instrumentation/jsp-2.3/src/test/groovy/JSPInstrumentationBasicTests.groovy

@@ -6,7 +6,6 @@ import okhttp3.Request
 import okhttp3.RequestBody
 import okhttp3.Response
 import org.apache.jasper.JasperException
-import org.eclipse.jetty.http.HttpStatus
 
 class JSPInstrumentationBasicTests extends JSPTestBase {
   def "non-erroneous GET #test test"() {
@@ -72,7 +71,7 @@ class JSPInstrumentationBasicTests extends JSPTestBase {
         }
       }
     }
-    res.code() == HttpStatus.OK_200
+    res.code() == HTTP_OK
 
     cleanup:
     res.close()
@@ -149,7 +148,7 @@ class JSPInstrumentationBasicTests extends JSPTestBase {
         }
       }
     }
-    res.code() == HttpStatus.OK_200
+    res.code() == HTTP_OK
 
     cleanup:
     res.close()
@@ -222,7 +221,7 @@ class JSPInstrumentationBasicTests extends JSPTestBase {
         }
       }
     }
-    res.code() == HttpStatus.OK_200
+    res.code() == HTTP_OK
 
     cleanup:
     res.close()
@@ -305,7 +304,7 @@ class JSPInstrumentationBasicTests extends JSPTestBase {
         }
       }
     }
-    res.code() == HttpStatus.INTERNAL_SERVER_ERROR_500
+    res.code() == HTTP_INTERNAL_ERROR
 
     cleanup:
     res.close()
@@ -380,7 +379,7 @@ class JSPInstrumentationBasicTests extends JSPTestBase {
         }
       }
     }
-    res.code() == HttpStatus.OK_200
+    res.code() == HTTP_OK
 
     cleanup:
     res.close()
@@ -503,7 +502,7 @@ class JSPInstrumentationBasicTests extends JSPTestBase {
         }
       }
     }
-    res.code() == HttpStatus.OK_200
+    res.code() == HTTP_OK
 
     cleanup:
     res.close()
@@ -561,7 +560,7 @@ class JSPInstrumentationBasicTests extends JSPTestBase {
         }
       }
     }
-    res.code() == HttpStatus.INTERNAL_SERVER_ERROR_500
+    res.code() == HTTP_INTERNAL_ERROR
 
     cleanup:
     res.close()
@@ -581,7 +580,7 @@ class JSPInstrumentationBasicTests extends JSPTestBase {
     Response res = client.newCall(req).execute()
 
     then:
-    res.code() == HttpStatus.OK_200
+    res.code() == HTTP_OK
     assertTraces(1) {
       trace(1) {
         span {

dd-java-agent/instrumentation/jsp-2.3/src/test/groovy/JSPInstrumentationForwardTests.groovy

@@ -3,7 +3,6 @@ import datadog.trace.bootstrap.instrumentation.api.Tags
 import okhttp3.Request
 import okhttp3.Response
 import org.apache.jasper.JasperException
-import org.eclipse.jetty.http.HttpStatus
 
 class JSPInstrumentationForwardTests extends JSPTestBase {
   def "non-erroneous GET forward to #forwardTo"() {
@@ -97,7 +96,7 @@ class JSPInstrumentationForwardTests extends JSPTestBase {
         }
       }
     }
-    res.code() == HttpStatus.OK_200
+    res.code() == HTTP_OK
 
     cleanup:
     res.close()
@@ -171,7 +170,7 @@ class JSPInstrumentationForwardTests extends JSPTestBase {
         }
       }
     }
-    res.code() == HttpStatus.OK_200
+    res.code() == HTTP_OK
 
     cleanup:
     res.close()
@@ -324,7 +323,7 @@ class JSPInstrumentationForwardTests extends JSPTestBase {
         }
       }
     }
-    res.code() == HttpStatus.OK_200
+    res.code() == HTTP_OK
 
     cleanup:
     res.close()
@@ -449,7 +448,7 @@ class JSPInstrumentationForwardTests extends JSPTestBase {
         }
       }
     }
-    res.code() == HttpStatus.OK_200
+    res.code() == HTTP_OK
 
     cleanup:
     res.close()
@@ -535,7 +534,7 @@ class JSPInstrumentationForwardTests extends JSPTestBase {
         }
       }
     }
-    res.code() == HttpStatus.INTERNAL_SERVER_ERROR_500
+    res.code() == HTTP_INTERNAL_ERROR
 
     cleanup:
     res.close()
@@ -604,7 +603,7 @@ class JSPInstrumentationForwardTests extends JSPTestBase {
         }
       }
     }
-    res.code() == HttpStatus.NOT_FOUND_404
+    res.code() == HTTP_NOT_FOUND
 
     cleanup:
     res.close()

dd-java-agent/instrumentation/jsp-2.3/src/test/groovy/JSPTestBase.groovy

@@ -26,6 +26,11 @@ abstract class JSPTestBase extends InstrumentationSpecification {
 
   OkHttpClient client = OkHttpUtils.client()
 
+  // HTTP status code constants
+  static final int HTTP_OK = 200
+  static final int HTTP_NOT_FOUND = 404
+  static final int HTTP_INTERNAL_ERROR = 500
+
   @Override
   void configurePreAgent() {
     super.configurePreAgent()