Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIGHUPs that happen during a check run are ignored #3785

Open
volfco opened this issue Oct 24, 2018 · 0 comments
Open

SIGHUPs that happen during a check run are ignored #3785

volfco opened this issue Oct 24, 2018 · 0 comments

Comments

@volfco
Copy link

volfco commented Oct 24, 2018 •
edited
Loading

I've noticed this bug. When you have a long running check, if the application sends a SIGHUP to reload the config during the execution phase; the SIGHUB is ignored.

This looks to be the result of the following line:

dd-agent/agent.py

Line 353 in 33afda6

self.reload_configs_flag = False

The above line should be moved above self.collector.run so if a SIGHUP happens during the check it's caught by the reload code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@volfco