Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classpath seperator on Windows is semicolon, Linux uses colon #3728

Open
jvanlieshout opened this issue Apr 30, 2018 · 1 comment
Open

Classpath seperator on Windows is semicolon, Linux uses colon #3728

jvanlieshout opened this issue Apr 30, 2018 · 1 comment

Comments

@jvanlieshout
Copy link
Contributor

dd-agent/jmxfetch.py

Lines 242 to 247 in 5d334d7

if tools_jar_path is not None:
classpath = r"%s:%s" % (tools_jar_path, classpath)
if custom_jar_paths:
classpath = r"%s:%s" % (':'.join(custom_jar_paths), classpath)
if self.config_jar_path:
classpath = r"%s:%s" % (self.config_jar_path, classpath)

When using jmxfetch on Windows with custom_jar_paths set (for instance when monitoring jboss on Windows) the classpath separator should be a semicolon (;). Using a colon (:) will only work on linux.

@jvanlieshout
Copy link
Contributor Author

I've submitted PR #3729 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant