Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus_check] check does not pickup summary metrics #3715

Open
waller-wg2 opened this issue Mar 26, 2018 · 1 comment
Open

[prometheus_check] check does not pickup summary metrics #3715

waller-wg2 opened this issue Mar 26, 2018 · 1 comment

Comments

@waller-wg2
Copy link

Summary metrics seems to get lost in parse_metric_family

Additional environment details (Operating System, Cloud provider, etc):
Debian 9

Steps to reproduce the issue:

  1. add any valid prometheus check
  2. make sure at least one metric of the scraped target is of type summary
  3. implement check accordning to https://docs.datadoghq.com/agent/prometheus/

Describe the results you received:
Summary metric is missing

Describe the results you expected:
Summary metric present

Additional information you deem important (e.g. issue happens only occasionally):
Seems the parse_metric_family skips the summary cause the metric name of a summary is never part
of messages since that holds the two actual metric names (x_count, x_sum)

if _m in messages or (obj_map[_m] == 'histogram' and ('{}_bucket'.format(_m) in messages)):

Needs similar handling as histogram?

@dnfehren
Copy link

Just ran into this as well. Is this due to the python client for prometheus? https://github.com/prometheus/client_python#summary says The Python client doesn't store or expose quantile information at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants