Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dogstreams does not pick up newly created log files when using wildcard #3700

Open
jonauman opened this issue Mar 6, 2018 · 2 comments
Open

Comments

@jonauman
Copy link

jonauman commented Mar 6, 2018

Additional environment details (Operating System, Cloud provider, etc):
OS: Linaro (Ubuntu)
Arch: armhf

Steps to reproduce the issue:

  1. Add this to datadog.conf:
    dogstreams: /home/cbuser/.cortex/log/player.json.*:/opt/datadog-agent/agent/cortex_log_plays.py:cortex_parser
  2. restart the agent

Describe the results you received:
As new logs appear (logrotate) over time, they do not get picked up by dogstreams.

Describe the results you expected:
I would expect that all logs matching the wildcard would get processed, not only the logs matching at time of agent startup.

Additional information you deem important (e.g. issue happens only occasionally):
Datadog support has provided a fix for collector.py (358-259):

357        if self._dogstream is not None:
358            if (self.run_count % 10) == 0:
359                self._dogstream = Dogstreams.init(log, self.agentConfig)

I have tested this patch and it works. Can we get this added into the codebase?

Since we are on armhf architecture, we must install the agent from source and would like to avoid having to patch the file every time we upgrade the agent.

Zendesk ticket 131296 was opened (and resolved) in reference to this issue.

jonauman pushed a commit to jonauman/dd-agent that referenced this issue Mar 7, 2018
re-instantiates the dogstream every 10 runs (approx. every 2 minutes)
@nsushain
Copy link

nsushain commented Apr 6, 2018

Can we get his merged? facing the same issue

hush-hush pushed a commit to jonauman/dd-agent that referenced this issue Aug 2, 2018
re-instantiates the dogstream every 10 runs (approx. every 2 minutes)
hush-hush pushed a commit that referenced this issue Aug 2, 2018
re-instantiates the dogstream every 10 runs (approx. every 2 minutes)
olivielpeau added a commit that referenced this issue Sep 26, 2018
This reverts commit 78e9ad4,
which introduced a file descriptor leak when dogstreams is enabled.
truthbk pushed a commit that referenced this issue Sep 26, 2018
This reverts commit 78e9ad4,
which introduced a file descriptor leak when dogstreams is enabled.
truthbk pushed a commit that referenced this issue Sep 26, 2018
This reverts commit 78e9ad4,
which introduced a file descriptor leak when dogstreams is enabled.
@edwardjlam
Copy link

is there any update on this? currently facing this issue as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants