chore: update dev dependencies to latest (#2603)

* chore: updated typescript eslint (#2600)

* chore: updated sonarjs eslint, configured/fixed new errors (#2600)

* chore: updated other eslint plugins (#2600)

* chore: updated, configured, reran prettier (#2600)

* chore: updated types/node (#2600)

* chore: updated got (#2600)

* chore: updated commitlint (#2600)

* fix: fixed commitlint version (#2600)

* chore: updated husky (#2600)

* chore: update remark-gfm (#2600)

* chore: resolve husky deprecation alert (#2600)

* chore: updated @digitak/esrun (#2600)

* chore: updated remaining typing dependencies (#2600)

* fix: moved dependencies used in the app out of devDependencies (#2600)

* chore: updated types/react (#2600)

* chore: updated next/eslint-plugin-next (#2600)

* chore: moved remark dependencies out of devDependencies (#2600)

* chore: updated types packages to match the main package version (#2600)

* chore: move next-mdx-remote and slugify from dev to prod dependencies (#2600)

Author: Jonah Paten

.eslintrc.json

@@ -15,7 +15,7 @@
     "prettier",
     "plugin:prettier/recommended",
     "next",
-    "plugin:sonarjs/recommended",
+    "plugin:sonarjs/recommended-legacy",
     "plugin:eslint-comments/recommended"
   ],
   "rules": {
@@ -58,7 +58,9 @@
     "jsdoc/require-returns-description": "error",
     "jsdoc/check-alignment": "error",
     "jsdoc/check-param-names": "error",
-    "react-hooks/exhaustive-deps": "error"
+    "react-hooks/exhaustive-deps": "error",
+    "sonarjs/todo-tag": "warn",
+    "sonarjs/redundant-type-aliases": "warn"
   },
   "overrides": [
     {

.husky/commit-msg

@@ -1,6 +1,3 @@
-#!/usr/bin/env sh
-. "$(dirname -- "$0")/_/husky.sh"
-
 echo "Checking commit message"
 
 # Check for issue number

.husky/pre-commit

@@ -1,6 +1,3 @@
-#!/bin/sh
-. "$(dirname "$0")/_/husky.sh"
-
 echo '🏗️👷 Checking your project before committing'
 
 # Check Prettier

.prettierrc.json

@@ -1 +1,3 @@
-{}
+{
+  "trailingComma": "es5"
+}

apis/azul/hca-dcp/common/utils.ts

@@ -70,7 +70,7 @@ export function isNullOrUndefined(value: any): boolean {
  */
 export function processAggregatedOrArrayValue<
   T,
-  K extends KeyOfTypeStringOrNullArray<T>
+  K extends KeyOfTypeStringOrNullArray<T>,
 >(responseValues: T[], key: K): string[] {
   // Aggregate key values across response values.
   const values = aggregateResponseValues(
@@ -91,7 +91,7 @@ export function processAggregatedOrArrayValue<
  */
 export function processAggregatedBooleanOrArrayValue<
   T,
-  K extends KeyOfTypeBooleanOrNullArray<T>
+  K extends KeyOfTypeBooleanOrNullArray<T>,
 >(responseValues: T[], key: K): string[] {
   // Aggregate key values across response values.
   const values = aggregateResponseValues(
@@ -114,7 +114,7 @@ export function processAggregatedBooleanOrArrayValue<
  */
 export function processAggregatedNumberEntityValue<
   T,
-  K extends KeyOfTypeNumberOrNull<T>
+  K extends KeyOfTypeNumberOrNull<T>,
 >(responseValues: T[], key: K): number {
   // Aggregate key values across response values.
   return aggregateNumericalResponseValues(responseValues, key);
@@ -129,7 +129,7 @@ export function processAggregatedNumberEntityValue<
  */
 export function processEntityArrayValue<
   T,
-  K extends KeyOfTypeStringOrNullArray<T>
+  K extends KeyOfTypeStringOrNullArray<T>,
 >(responseValues: T[], key: K, label = LABEL.UNSPECIFIED): string[] {
   // Response values should be a singleton array; check for at least one value here.
   if (responseValues.length === 0) {
@@ -202,7 +202,7 @@ export function processNumberEntityValue<T, K extends KeyOfTypeNumberOrNull<T>>(
  */
 function aggregateNumericalResponseValues<
   T,
-  K extends KeyOfTypeNumberOrNull<T>
+  K extends KeyOfTypeNumberOrNull<T>,
 >(responseValues: T[], key: K): number {
   return responseValues
     .map((responseValue) => responseValue[key] as unknown as number)
@@ -217,7 +217,7 @@ function aggregateNumericalResponseValues<
  */
 function aggregateResponseValues<
   T,
-  K extends KeyOfTypeStringOrNullArray<T> | KeyOfTypeBooleanOrNullArray<T>
+  K extends KeyOfTypeStringOrNullArray<T> | KeyOfTypeBooleanOrNullArray<T>,
 >(responseValues: T[], key: K): StringOrNullArray | BooleanOrNullArray {
   return responseValues
     .filter((responseValue) => !!responseValue[key])

components/Home/components/SectionHero/sectionHero.styles.ts

@@ -61,10 +61,14 @@ export const CTAs = styled.div`
   justify-self: center;
 
   & .MuiButton-containedSecondary {
-    box-shadow: inset 0 0 0 1px ${smokeDark}, 0 1px 0 0 ${primaryDark};
+    box-shadow:
+      inset 0 0 0 1px ${smokeDark},
+      0 1px 0 0 ${primaryDark};
 
     &:hover {
-      box-shadow: inset 0 0 0 1px ${smokeDark}, 0 1px 0 0 ${primaryDark};
+      box-shadow:
+        inset 0 0 0 1px ${smokeDark},
+        0 1px 0 0 ${primaryDark};
     }
 
     &:active {

components/Home/components/SectionStayUpToDate/sectionStayUpToDate.tsx

@@ -16,6 +16,7 @@ export const SectionStayUpToDate = (): JSX.Element => {
       <SectionContent>
         <SectionHead>Stay up-to-date with the Human Cell Atlas</SectionHead>
         <CTAs>
+          {/* eslint-disable sonarjs/link-with-target-blank -- rule doesn't recognize constant */}
           <ButtonSecondary
             onClick={(): void => {
               window.open(
@@ -27,6 +28,7 @@ export const SectionStayUpToDate = (): JSX.Element => {
           >
             Join The HCA
           </ButtonSecondary>
+          {/* eslint-enable sonarjs/link-with-target-blank -- keep checking future noopener cases */}
         </CTAs>
       </SectionContent>
     </Section>