Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box class: Read-only property-getters for offset, root, raw and parent fields #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tchakabam
Copy link

@tchakabam tchakabam commented Jul 6, 2017

@tieleman hey, i'd find this kind of functions useful, what do you think?

I reconned that there is a problem with the general design of your box class. It would be better if the read iso fields would be in a props member-object that holds all the values like a dictionnary instead of using the main object as this dictionnary. that will allow to implement utility methods like these on top of the main class.

@tchakabam
Copy link
Author

(and obviously i would write some tests if this is seen as a useful feature)

@tieleman
Copy link
Contributor

@tchakabam: Yes, I can see the usefulness of this. I'm currently a bit swamped in work, but tests would be nice yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants