Box class: Read-only property-getters for offset, root, raw and parent fields #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tieleman hey, i'd find this kind of functions useful, what do you think?
I reconned that there is a problem with the general design of your box class. It would be better if the read iso fields would be in a
props
member-object that holds all the values like a dictionnary instead of using the main object as this dictionnary. that will allow to implement utility methods like these on top of the main class.