[BUG] Biomes O'Plenty compatibility missing in 1.21.1?

[JangoBritt]

Minecraft Version

1.21.1

Mod Version

21.1.41

Mod Loader

NeoForge

What environment are you running the mod in?

All

Issue Description

So I've had a look through the datapacks, and I can see that Biomes O'Plenty compatibility existed in 1.20.1, but that isn't in the list for 1.21.1.

I've run the debug command to get the missing seeds, but I'm not familiar with java modding (though I could pick it up with some direction) - how do I add all these missing plants to create a datapack for things that are missing?

Are there any example datapacks I could copy? What do I do with a datapack once I've created it?

[JangoBritt]

I've done some further research...

I thought I'd created a datapack for this, but it doesn't seem to be working.

I've created a zip called fables-botany.zip and placed it in the saves/Test World/datapacks folder.

/datapack list shows that the datapack is loaded, however when I run the debug command, /botanypots debug place_seeds ~ ~ ~false I don't get any more than I had before, and testing manually still doesn't produce any results

The pack.mcmeta says

  "pack": {
    "pack_format": 41,
    "description": "Adds support for missing Botany Pots on Fables Create"
  }
}

The folder structure is:

data
 - fables-recipes
    - recipes
       - biomesoplenty
           - crop
               - (eg.) barley.json
           - soil
               - (eg.) origin_grass.json

and the barley.json file (for example) has:

{
  "bookshelf:load_conditions": [
    {
      "type": "bookshelf:block_exists",
      "values": [
        "biomesoplenty:barley"
      ]
    }
  ],
  "type": "botanypots:block_derived_crop",
  "block": "biomesoplenty:barley",
  "input": {
    "item": "biomesoplenty:barley"
  }
}

I compared this to existing files that I know work. I found on this github, for example:
common/src/main/resources/data/botanypots/recipe/farmersdelight/crop/onion.json

Any help or guidance on this would be greatly appreciated

[JangoBritt]

alright - I got it figured out - I had my folder structure wrong.

I changed it to:

data
 - botanypots
    - recipe
       - biomesoplenty
           - crop
               - (eg.) barley.json
           - soil
               - (eg.) origin_grass.json

and it works

[Omegapsychosis]

Would you mind sharing your datapack by chance?

[Ser-Nick-22]

Same this would be vary nice

[JangoBritt]

http://www.fables-of-folly.com/uploads/java/BOPany_pots.zip

Not everything works properly though

[Ser-Nick-22]

Mostly have the same problem with only the saplings working but that's do to botany trees so slightly different. Also I thot compatibility was on the other mods side mostly.

[Ser-Nick-22]

Also give yourself some more credit. Apart from the big clover leaf everything seems to work just fine. And on that maybe just make it a super Small chance when growing normal clover.

[JangoBritt]

I can't get brimstone cluster growing on brimstone, nor the eyebulb growing on flesh

it's the custom soils that I haven't been able to get working, basically

[Ser-Nick-22]

I know a guy on the adorable hamsters mod discord just added compatibility with there moded plants he may be able to help ya. He goes by causal animal enjoyer